Skip to content

Commit 015a364

Browse files
Apply suggestions from code review
Co-authored-by: Sergey Semenov <[email protected]>
1 parent 2857d9d commit 015a364

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

sycl/include/sycl/detail/common.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ class __SYCL_EXPORT tls_code_loc_t {
144144
/// entry has been set up, a default coe location is returned.
145145
const detail::code_location &query();
146146
/// @brief Returns true if the TLS slot was cleared when this object was
147-
/// cunstructed.
147+
/// constructed.
148148
bool isToplevel() const { return !MLocalScope; }
149149

150150
private:

sycl/source/detail/queue_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ event queue_impl::submitWithHandler(const std::shared_ptr<queue_impl> &Self,
415415
CGH.depends_on(DepEvents);
416416
HandlerFunc(CGH);
417417
},
418-
Self, {}, true);
418+
Self, /*CodeLoc*/ {}, /*IsTopCodeLoc*/ true);
419419
}
420420

421421
template <typename HandlerFuncT, typename MemOpFuncT, typename... MemOpArgTs>

sycl/source/detail/scheduler/commands.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1993,9 +1993,9 @@ void instrumentationAddExtraKernelMetadata(
19931993
if (!SyclKernel->isCreatedFromSource())
19941994
EliminatedArgMask = SyclKernel->getKernelArgMask();
19951995
} else if (Queue) {
1996-
// NOTE: Queue can be null when kerner is directly enqueued to a command
1996+
// NOTE: Queue can be null when kernel is directly enqueued to a command
19971997
// buffer
1998-
// by graph API, when a midifiable graph is finalized.
1998+
// by graph API, when a modifiable graph is finalized.
19991999
std::tie(Kernel, KernelMutex, EliminatedArgMask, Program) =
20002000
detail::ProgramManager::getInstance().getOrCreateKernel(
20012001
Queue->getContextImplPtr(), Queue->getDeviceImplPtr(), KernelName);
@@ -2117,9 +2117,8 @@ std::pair<xpti_td *, uint64_t> emitKernelInstrumentationData(
21172117

21182118
if (CmdTraceEvent) {
21192119
// Stash the queue_id mutable metadata in TLS
2120-
// NOTE: Queue can be null when kerner is directly enqueued to a command
2121-
// buffer
2122-
// by graph API, when a midifiable graph is finalized.
2120+
// NOTE: Queue can be null when kernel is directly enqueued to a command
2121+
// buffer by graph API, when a modifiable graph is finalized.
21232122
if (Queue.get())
21242123
xpti::framework::stash_tuple(XPTI_QUEUE_INSTANCE_ID_KEY,
21252124
getQueueID(Queue));

sycl/unittests/xpti_trace/NodeCreation.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,7 @@ TEST_F(NodeCreation, CommandGraphRecord) {
167167

168168
auto exeGraph = cmdGraph.finalize();
169169

170-
// Notifications should have get generated during finalize
171-
//
170+
// Notifications should have been generated during finalize
172171
uint16_t TraceType = 0;
173172
std::string Message;
174173
ASSERT_TRUE(queryReceivedNotifications(TraceType, Message));

0 commit comments

Comments
 (0)