Address review comments

Author: jzc

sycl/source/detail/device_binary_image.cpp

@@ -84,7 +84,7 @@ std::string_view DeviceBinaryProperty::asStringView() const {
   assert(Prop->ValSize > 0 && "property size mismatch");
   // Byte array stores its size in first 8 bytes
   size_t Shift = Prop->Type == SYCL_PROPERTY_TYPE_BYTE_ARRAY ? 8 : 0;
-  return {ur::cast<const char *>(Prop->ValAddr) + Shift, Prop->ValSize};
+  return {ur::cast<const char *>(Prop->ValAddr) + Shift, Prop->ValSize - Shift};
 }
 
 void RTDeviceBinaryImage::PropertyRange::init(sycl_device_binary Bin,

sycl/source/detail/program_manager/program_manager.cpp

@@ -748,8 +748,9 @@ ProgramManager::collectDependentDeviceImagesForVirtualFunctions(
       // when the dummy image does not support the device requirements, we
       // know the corresponding image providing virtual functions was not
       // linked and we must link the dummy image.
-      if (doesDevSupportDeviceRequirements(Dev, *BinImage) + isDummyImage == 1)
+      if (doesDevSupportDeviceRequirements(Dev, *BinImage) ^ isDummyImage)
         DeviceImagesToLink.insert(BinImage);
+
     }
   }
 

sycl/unittests/Extensions/VirtualFunctions/RuntimeLinking.cpp

@@ -370,7 +370,7 @@ TEST(VirtualFunctions, DummyImages) {
 
   CapturedLinkingData.clear();
 
-  EXPECT_EQ(Plt.get_devices().size(), 2);
+  EXPECT_EQ(Plt.get_devices().size(), 2u);
   sycl::queue Q2(sycl::aspect_selector({}, {sycl::aspect::fp64}));
 
   // We now repeat what we did launching KernelH but on another