Skip to content

Commit 1469a2a

Browse files
committed
add missing \, standardize cmd arg opts
1 parent 5ff2249 commit 1469a2a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

devops/actions/run-tests/benchmark_v2/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,13 @@ runs:
112112
--output-html remote \
113113
--results-dir "./llvm-ci-perf-results/$RUNNER_NAME" \
114114
--output-dir "./llvm-ci-perf-results/$RUNNER_NAME" \
115-
--preset Minimal
115+
--preset Minimal \
116116
--timestamp-override "$SAVE_TIMESTAMP"
117117
echo "-----"
118118
python3 ./devops/scripts/benchmarks/compare.py to_hist \
119119
--name Baseline_PVC_L0 \
120-
--compare_file "./llvm-ci-perf-results/$RUNNER_NAME/results/$SAVE_NAME_$SAVE_TIMESTAMP.json"
121-
--results_dir "./llvm-ci-perf-results/$RUNNER_NAME/results/"
120+
--compare-file "./llvm-ci-perf-results/$RUNNER_NAME/results/$SAVE_NAME_$SAVE_TIMESTAMP.json"
121+
--results-dir "./llvm-ci-perf-results/$RUNNER_NAME/results/"
122122
123123
- name: Push compute-benchmarks results
124124
if: inputs.upload_results == 'true' && always()

devops/scripts/benchmarks/compare.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ def to_hist(
231231
subparsers = parser.add_subparsers(dest="operation", required=True)
232232
parser_avg = subparsers.add_parser("to_hist", help="Compare a benchmark result to historic average")
233233
parser_avg.add_argument(
234-
"--avg_type",
234+
"--avg-type",
235235
type=str,
236236
help="Measure of central tendency to use when computing historic average",
237237
default="median"
@@ -243,13 +243,13 @@ def to_hist(
243243
help="Save name of the benchmark results to compare to"
244244
)
245245
parser_avg.add_argument(
246-
"--compare_file",
246+
"--compare-file",
247247
type=str,
248248
required=True,
249249
help="Result file to compare against te historic average"
250250
)
251251
parser_avg.add_argument(
252-
"--results_dir",
252+
"--results-dir",
253253
type=str,
254254
required=True,
255255
help="Directory storing results"

0 commit comments

Comments
 (0)