Fix two pessimizing moves.

chsigg · chsigg · commit 2fe625e9abd0 · 2021-01-08T11:44:29.000+01:00
See https://en.cppreference.com/w/cpp/language/return#Automatic_move_from_local_variables_and_parameters Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D94218
diff --git a/llvm/include/llvm/Support/TaskQueue.h b/llvm/include/llvm/Support/TaskQueue.h
@@ -98,7 +98,7 @@ class TaskQueue {
         IsTaskInFlight = true;
       }
     }
-    return std::move(F);
+    return F;
   }
 
 private:
diff --git a/mlir/include/mlir/Parser.h b/mlir/include/mlir/Parser.h
@@ -67,7 +67,7 @@ inline OwningOpRef<ContainerOpT> constructContainerOpForParserIfNecessary(
   // contain the operations inside of it.
   if (failed(op.verify()))
     return OwningOpRef<ContainerOpT>();
-  return std::move(opRef);
+  return opRef;
 }
 } // end namespace detail
 

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ class TaskQueue {`
`98`	`98`	`IsTaskInFlight = true;`
`99`	`99`	`}`
`100`	`100`	`}`
`101`		`- return std::move(F);`
	`101`	`+ return F;`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`private:`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ inline OwningOpRef<ContainerOpT> constructContainerOpForParserIfNecessary(`
`67`	`67`	`// contain the operations inside of it.`
`68`	`68`	`if (failed(op.verify()))`
`69`	`69`	`return OwningOpRef<ContainerOpT>();`
`70`		`- return std::move(opRef);`
	`70`	`+ return opRef;`
`71`	`71`	`}`
`72`	`72`	`} // end namespace detail`
`73`	`73`