Skip to content

Commit 30612c6

Browse files
committed
[SYCL] Fix 'move instead of copy' Coverity hits
1 parent 7d40de9 commit 30612c6

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

sycl/source/detail/config.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ template <> class SYCLConfig<SYCL_JIT_AMDGCN_PTX_TARGET_CPU> {
652652
const char *ValStr = getCachedValue();
653653

654654
if (!ValStr)
655-
return DefaultValue;
655+
return std::move(DefaultValue);
656656

657657
return std::string{ValStr};
658658
}

sycl/source/detail/jit_compiler.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1044,14 +1044,16 @@ jit_compiler::fuseKernels(QueueImplPtr Queue,
10441044
std::shared_ptr<detail::kernel_bundle_impl> KernelBundleImplPtr;
10451045
if (TargetFormat == ::jit_compiler::BinaryFormat::SPIRV) {
10461046
detail::getSyclObjImpl(get_kernel_bundle<bundle_state::executable>(
1047-
Queue->get_context(), {Queue->get_device()}, {FusedKernelId}));
1047+
Queue->get_context(), {Queue->get_device()},
1048+
{std::move(FusedKernelId)}));
10481049
}
10491050

10501051
std::unique_ptr<detail::CG> FusedCG;
10511052
FusedCG.reset(new detail::CGExecKernel(
10521053
NDRDesc, nullptr, nullptr, std::move(KernelBundleImplPtr),
1053-
std::move(CGData), std::move(FusedArgs), FusedOrCachedKernelName, {}, {},
1054-
CGType::Kernel, KernelCacheConfig, false /* KernelIsCooperative */,
1054+
std::move(CGData), std::move(FusedArgs),
1055+
std::move(FusedOrCachedKernelName), {}, {}, CGType::Kernel,
1056+
KernelCacheConfig, false /* KernelIsCooperative */,
10551057
false /* KernelUsesClusterLaunch*/, 0 /* KernelWorkGroupMemorySize */));
10561058
return FusedCG;
10571059
}

sycl/source/detail/scheduler/scheduler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ ur_kernel_handle_t Scheduler::completeSpecConstMaterialization(
593593
[[maybe_unused]] std::vector<unsigned char> &SpecConstBlob) {
594594
#if SYCL_EXT_JIT_ENABLE && !_WIN32
595595
return detail::jit_compiler::get_instance().materializeSpecConstants(
596-
Queue, BinImage, KernelName, SpecConstBlob);
596+
std::move(Queue), BinImage, KernelName, SpecConstBlob);
597597
#else // SYCL_EXT_JIT_ENABLE && !_WIN32
598598
if (detail::SYCLConfig<detail::SYCL_RT_WARNING_LEVEL>::get() > 0) {
599599
std::cerr << "WARNING: Materialization of spec constants not supported by "

0 commit comments

Comments
 (0)