Skip to content

Commit 33b50db

Browse files
[SYCL] test improvement, issue 16309 (#16389)
The kernel-bundle-merge-options test was recently marked XFAIL (and tracker #16309 opened). The root problem is that when using the MSVC CL compiler, the tests set the `debug_option` flag to `/DEBUG` but it is `/Zi` that gets converted to `-g` when the device driver is called. Updating that python var and removing the `XFAIL` from the test.
1 parent d21e679 commit 33b50db

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

sycl/test-e2e/KernelAndProgram/kernel-bundle-merge-options.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,19 @@
33
// RUN: env SYCL_UR_TRACE=2 %{run} %t.out | FileCheck %s
44
// UNSUPPORTED: hip
55

6-
// Debug option -g is not passed to device code compiler when CL-style driver
7-
// is used and /DEBUG options is passed.
8-
// XFAIL: cl_options
9-
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16309
6+
// Note that the UR call might be urProgramBuild OR urProgramBuildExp .
7+
// The same is true for Compile and Link.
8+
// We want the first match. Don't put parentheses after.
109

1110
#include "kernel-bundle-merge-options.hpp"
1211

1312
// CHECK: <--- urProgramBuild
1413
// CHECK-SAME: -g
1514

16-
// TODO: Uncomment when build options are properly passed to compile and link
15+
// CHECK: <--- urProgramCompile
16+
// CHECK-SAME: -g
17+
18+
// TODO: Uncomment when build options are properly passed to link
1719
// commands for kernel_bundle
18-
// xCHECK: <--- urProgramCompile(
19-
// xCHECK-SAME: -g
20-
// xCHECK: <--- urProgramLink(
20+
// xCHECK: <--- urProgramLink
2121
// xCHECK-SAME: -g

sycl/test-e2e/lit.cfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ def open_check_file(file_name):
381381
)
382382
)
383383
config.substitutions.append(("%include_option", "/FI"))
384-
config.substitutions.append(("%debug_option", "/DEBUG"))
384+
config.substitutions.append(("%debug_option", "/Zi /DEBUG"))
385385
config.substitutions.append(("%cxx_std_option", "/std:"))
386386
config.substitutions.append(("%fPIC", ""))
387387
config.substitutions.append(("%shared_lib", "/LD"))

0 commit comments

Comments
 (0)