Incorportate review feedback

Author: Fznamznon

clang/lib/Sema/SemaSYCL.cpp

@@ -1452,7 +1452,7 @@ class KernelObjVisitor {
     else if (ParamTy->isStructureOrClassType()) {
       if (KF_FOR_EACH(handleStructType, Param, ParamTy)) {
         CXXRecordDecl *RD = ParamTy->getAsCXXRecordDecl();
-        visitRecord(RD, Param, RD, ParamTy, Handlers...);
+        visitRecord(nullptr, Param, RD, ParamTy, Handlers...);
       }
     } else if (ParamTy->isUnionType())
       KP_FOR_EACH(handleOtherType, Param, ParamTy);
@@ -1980,7 +1980,11 @@ class SyclKernelFieldChecker : public SyclKernelFieldHandler {
 
     // Check that the type is defined at namespace scope.
     const DeclContext *DeclCtx = RD->getDeclContext();
-    if (!DeclCtx->isTranslationUnit() && !isa<NamespaceDecl>(DeclCtx)) {
+    while (!DeclCtx->isTranslationUnit() &&
+           (isa<NamespaceDecl>(DeclCtx) || isa<LinkageSpecDecl>(DeclCtx)))
+      DeclCtx = DeclCtx->getParent();
+
+    if (!DeclCtx->isTranslationUnit()) {
       Diag.Report(PD->getLocation(), diag::err_bad_kernel_param_type)
           << ParamTy;
       IsInvalid = true;
@@ -3017,13 +3021,13 @@ class SyclKernelDeclCreator : public SyclKernelFieldHandler {
 
   bool handleNonDecompStruct(const CXXRecordDecl *RD, ParmVarDecl *PD,
                              QualType ParamTy) final {
-    // This is a field which should not be decomposed.
-    CXXRecordDecl *FieldRecordDecl = ParamTy->getAsCXXRecordDecl();
-    assert(FieldRecordDecl && "Type must be a C++ record type");
+    // This is a struct parameter which should not be decomposed.
+    CXXRecordDecl *ParamRecordDecl = ParamTy->getAsCXXRecordDecl();
+    assert(ParamRecordDecl && "Type must be a C++ record type");
     // Check if we need to generate a new type for this record,
     // i.e. this record contains pointers.
-    if (FieldRecordDecl->hasAttr<SYCLGenerateNewTypeAttr>())
-      addParam(PD, GenerateNewRecordType(FieldRecordDecl));
+    if (ParamRecordDecl->hasAttr<SYCLGenerateNewTypeAttr>())
+      addParam(PD, GenerateNewRecordType(ParamRecordDecl));
     else
       addParam(PD, ParamTy);
     return true;

clang/test/SemaSYCL/free_function_kernel_params_restrictions.cpp

@@ -29,3 +29,14 @@ void bar() {
 auto Glob = [](int P){ return P + 1;};
 
 template void ff_6(typeof(Glob) S1);
+
+extern "C" {
+  struct A {
+    int a;
+  };
+}
+
+__attribute__((sycl_device))
+[[__sycl_detail__::add_ir_attributes_function("sycl-single-task-kernel", 0)]]
+void ff_5(A S1) {
+}