Skip to content

Commit 3689e80

Browse files
committed
Move MKernelIsCooperative to KernelData
1 parent b4908d0 commit 3689e80

File tree

6 files changed

+17
-9
lines changed

6 files changed

+17
-9
lines changed

sycl/source/detail/handler_impl.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ class handler_impl {
106106

107107
ur_kernel_cache_config_t MKernelCacheConfig = UR_KERNEL_CACHE_CONFIG_DEFAULT;
108108

109-
bool MKernelIsCooperative = false;
110109
uint32_t MKernelWorkGroupMemorySize = 0;
111110

112111
// Extra information for bindless image copy

sycl/source/detail/kernel_data.hpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ class KernelData {
115115

116116
bool usesAssert() const { return MDeviceKernelInfoPtr->usesAssert(); }
117117

118+
bool isCooperative() const { return MKernelIsCooperative; }
119+
120+
void setCooperative(bool IsCooperative) {
121+
MKernelIsCooperative = IsCooperative;
122+
}
123+
118124
bool usesClusterLaunch() const { return MKernelUsesClusterLaunch; }
119125

120126
template <int Dims_> void setClusterDimensions(sycl::range<Dims_> N) {
@@ -138,6 +144,7 @@ class KernelData {
138144
/// The list of arguments for the kernel.
139145
std::vector<detail::ArgDesc> MArgs;
140146

147+
bool MKernelIsCooperative = false;
141148
bool MKernelUsesClusterLaunch = false;
142149

143150
/// Struct that encodes global size, local size, ...

sycl/source/handler.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ event handler::finalize() {
664664
MKernel.get(), toKernelNameStrT(MKernelName),
665665
*impl->MKernelData.getDeviceKernelInfoPtr(), RawEvents,
666666
ResultEvent.get(), nullptr, impl->MKernelCacheConfig,
667-
impl->MKernelIsCooperative,
667+
impl->MKernelData.isCooperative(),
668668
impl->MKernelData.usesClusterLaunch(),
669669
impl->MKernelWorkGroupMemorySize, BinImage,
670670
impl->MKernelData.getKernelFuncPtr(),
@@ -731,7 +731,7 @@ event handler::finalize() {
731731
toKernelNameStrT(MKernelName),
732732
*impl->MKernelData.getDeviceKernelInfoPtr(), std::move(MStreamStorage),
733733
std::move(impl->MAuxiliaryResources), getType(),
734-
impl->MKernelCacheConfig, impl->MKernelIsCooperative,
734+
impl->MKernelCacheConfig, impl->MKernelData.isCooperative(),
735735
impl->MKernelData.usesClusterLaunch(), impl->MKernelWorkGroupMemorySize,
736736
MCodeLoc));
737737
break;
@@ -2023,7 +2023,7 @@ void handler::setKernelCacheConfig(handler::StableKernelCacheConfig Config) {
20232023
}
20242024

20252025
void handler::setKernelIsCooperative(bool KernelIsCooperative) {
2026-
impl->MKernelIsCooperative = KernelIsCooperative;
2026+
impl->MKernelData.setCooperative(KernelIsCooperative);
20272027
}
20282028

20292029
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES

sycl/unittests/program_manager/arg_mask/EliminatedArgMask.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,9 @@ class MockHandler : public sycl::handler {
151151
std::move(impl->MKernelData).getArgs(), CGH->MKernelName.data(),
152152
*impl->MKernelData.getDeviceKernelInfoPtr(),
153153
std::move(CGH->MStreamStorage), std::move(impl->MAuxiliaryResources),
154-
impl->MCGType, {}, impl->MKernelIsCooperative,
155-
impl->MKernelUsesClusterLaunch, impl->MKernelWorkGroupMemorySize,
156-
CGH->MCodeLoc));
154+
impl->MCGType, {}, impl->MKernelData.isCooperative(),
155+
impl->MKernelData.usesClusterLaunch(),
156+
impl->MKernelWorkGroupMemorySize, CGH->MCodeLoc));
157157
break;
158158
}
159159
default:

sycl/unittests/scheduler/SchedulerTestUtils.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,8 @@ class MockHandlerCustomFinalize : public MockHandler {
309309
std::move(impl->MKernelBundle), std::move(CGData), getArgs(),
310310
getKernelName(), *impl->MKernelData.getDeviceKernelInfoPtr(),
311311
getStreamStorage(), impl->MAuxiliaryResources, getType(), {},
312-
impl->MKernelIsCooperative, impl->MKernelUsesClusterLaunch,
312+
impl->MKernelData.isCooperative(),
313+
impl->MKernelData.usesClusterLaunch(),
313314
impl->MKernelWorkGroupMemorySize, getCodeLoc()));
314315
break;
315316
}

sycl/unittests/scheduler/StreamInitDependencyOnHost.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ class MockHandlerStreamInit : public MockHandler {
3636
getArgs(), getKernelName(),
3737
*impl->MKernelData.getDeviceKernelInfoPtr(), getStreamStorage(),
3838
std::move(impl->MAuxiliaryResources), getType(), {},
39-
impl->MKernelIsCooperative, impl->MKernelUsesClusterLaunch,
39+
impl->MKernelData.isCooperative(),
40+
impl->MKernelData.usesClusterLaunch(),
4041
impl->MKernelWorkGroupMemorySize, getCodeLoc()));
4142
break;
4243
}

0 commit comments

Comments
 (0)