Skip to content

Commit 3b05692

Browse files
[CI] Cleanup E2E matrix codes (#19741)
* Add default value for `image_options` * Drop unused `matrix-xmx8` * Don't set `gpu-intel-gen12`, rely on auto-detection in https://github.com/intel/llvm/blob/dc8068fe687b24a0f8018ea6c43fc4f9183f9bb7/sycl/test-e2e/lit.cfg.py#L240-L256 * Align naming of the individual matrix jobs
1 parent edb2472 commit 3b05692

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

.github/workflows/sycl-linux-precommit.yml

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,7 @@ jobs:
8888
include:
8989
- name: GEN 12 Integrated
9090
runner: '["Linux", "gen12"]'
91-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
9291
target_devices: level_zero:gpu;opencl:gpu;opencl:cpu
93-
extra_lit_opts: --param gpu-intel-gen12=True
9492
- name: NVIDIA/CUDA
9593
runner: '["Linux", "cuda"]'
9694
image_options: -u 1001 --gpus all --cap-add SYS_ADMIN
@@ -102,35 +100,27 @@ jobs:
102100
extra_lit_opts: -j 1
103101
- name: Intel Arc A-Series Graphics
104102
runner: '["Linux", "arc"]'
105-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
106103
target_devices: level_zero:gpu;opencl:gpu;level_zero_v2:gpu
107-
extra_lit_opts: --param matrix-xmx8=True
108-
- name: E2E tests with dev igc on Intel Arc A-Series Graphics
104+
- name: Dev IGC / Intel Arc A-Series Graphics
109105
runner: '["Linux", "arc"]'
110106
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
111-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
112107
target_devices: level_zero:gpu
113-
extra_lit_opts: --param matrix-xmx8=True
114108
use_igc_dev: true
115109
env: '{"LIT_FILTER":"Matrix/"}'
116-
- name: E2E tests on Intel Ponte Vecchio GPU
110+
- name: Intel Ponte Vecchio GPU
117111
runner: '["Linux", "pvc"]'
118-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
119112
target_devices: level_zero:gpu;opencl:gpu;level_zero_v2:gpu
120-
- name: Dev IGC on Intel Ponte Vecchio GPU
113+
- name: Dev IGC / Intel Ponte Vecchio GPU
121114
runner: '["Linux", "pvc"]'
122115
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
123-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
124116
target_devices: level_zero:gpu
125117
use_igc_dev: true
126118
env: '{"LIT_FILTER":"Matrix/"}'
127119
- name: Intel Battlemage Graphics
128120
runner: '["Linux", "bmg"]'
129-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
130121
target_devices: level_zero_v1:gpu;level_zero_v2:gpu
131122
- name: Preview Mode
132123
runner: '["Linux", "gen12"]'
133-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
134124
target_devices: level_zero:gpu;opencl:gpu;opencl:cpu
135125
extra_lit_opts: --param test-preview-mode=True
136126
e2e_binaries_artifact: e2e_bin_preview
@@ -140,7 +130,7 @@ jobs:
140130
name: ${{ matrix.name }}
141131
runner: ${{ matrix.runner }}
142132
image: ${{ matrix.image }}
143-
image_options: ${{ matrix.image_options }}
133+
image_options: ${{ matrix.image_options || '-u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN' }}
144134
target_devices: ${{ matrix.target_devices }}
145135
extra_lit_opts: ${{ matrix.extra_lit_opts }}
146136
repo_ref: ${{ github.sha }}

.github/workflows/sycl-nightly.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,27 +84,22 @@ jobs:
8484

8585
- name: Intel L0 Gen12 GPU
8686
runner: '["Linux", "gen12"]'
87-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
8887
target_devices: level_zero:gpu
8988

9089
- name: Intel L0 Ponte Vecchio GPU
9190
runner: '["Linux", "pvc"]'
92-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
9391
target_devices: level_zero:gpu
9492

9593
- name: Intel L0 Battlemage GPU
9694
runner: '["Linux", "bmg"]'
97-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
9895
target_devices: level_zero:gpu
9996

10097
- name: Intel L0 Arc A-Series GPU
10198
runner: '["Linux", "arc"]'
102-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
10399
target_devices: level_zero:gpu
104100

105101
- name: Intel OCL Gen12 GPU
106102
runner: '["Linux", "gen12"]'
107-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
108103
target_devices: opencl:gpu
109104

110105
- name: OCL CPU (AMD)
@@ -124,15 +119,14 @@ jobs:
124119

125120
- name: Preview mode on SPR/PVC
126121
runner: '["Linux", "pvc"]'
127-
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
128122
target_devices: level_zero:gpu
129123
extra_lit_opts: --param test-preview-mode=True
130124

131125
uses: ./.github/workflows/sycl-linux-run-tests.yml
132126
with:
133127
name: ${{ matrix.name }}
134128
runner: ${{ matrix.runner }}
135-
image_options: ${{ matrix.image_options }}
129+
image_options: ${{ matrix.image_options || '-u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN' }}
136130
target_devices: ${{ matrix.target_devices }}
137131
tests_selector: e2e
138132
extra_lit_opts: "--param 'cxx_flags=-D_GLIBCXX_USE_CXX11_ABI=0' ${{ matrix.extra_lit_opts }}"

.github/workflows/sycl-post-commit.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ jobs:
5757
target_devices: level_zero:gpu
5858
- name: Intel Arc A-Series Graphics with Level Zero
5959
runner: '["Linux", "arc"]'
60-
extra_lit_opts: --param matrix-xmx8=True
6160
# Performance tests below. Specifics:
6261
# - only run performance tests (use LIT_FILTER env)
6362
# - ask llvm-lit to show all the output, even for PASS (-a)

0 commit comments

Comments
 (0)