Apply review comments

Author: AlexeySachkov

sycl/include/sycl/detail/spirv.hpp

@@ -1239,12 +1239,12 @@ ControlBarrier(Group, [[maybe_unused]] memory_scope FenceScope,
 template <typename Group>
 typename std::enable_if_t<
     ext::oneapi::experimental::is_user_constructed_group_v<Group>>
-ControlBarrier(Group g, [[maybe_unused]] memory_scope FenceScope,
+ControlBarrier([[maybe_unused]] Group g,
+               [[maybe_unused]] memory_scope FenceScope,
                [[maybe_unused]] memory_order Order) {
 #if defined(__NVPTX__)
   __nvvm_bar_warp_sync(detail::ExtractMask(detail::GetMask(g))[0]);
 #elif defined(__SYCL_DEVICE_ONLY__)
-  (void)g;
   // SPIR-V does not define an instruction to synchronize partial groups.
   // However, most (possibly all?) of the current SPIR-V targets execute
   // work-items in lockstep, so we can probably get away with a MemoryBarrier.

sycl/source/detail/platform_util.cpp

@@ -131,28 +131,6 @@ uint32_t PlatformUtil::getNativeVectorWidth(PlatformUtil::TypeIndex TIndex) {
   return 0;
 }
 
-#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
-void PlatformUtil::prefetch(const char *Ptr, size_t NumBytes) {
-  if (!Ptr)
-    return;
-
-  const size_t CacheLineSize = PlatformUtil::getMemCacheLineSize();
-  const size_t CacheLineMask = ~(CacheLineSize - 1);
-  const char *PtrEnd = Ptr + NumBytes;
-
-  // Set the pointer to the beginning of the current cache line.
-  Ptr = reinterpret_cast<const char *>(reinterpret_cast<size_t>(Ptr) &
-                                       CacheLineMask);
-  for (; Ptr < PtrEnd; Ptr += CacheLineSize) {
-#if defined(__SYCL_RT_OS_LINUX)
-    __builtin_prefetch(Ptr);
-#elif defined(__SYCL_RT_OS_WINDOWS)
-    _mm_prefetch(Ptr, _MM_HINT_T0);
-#endif
-  }
-}
-#endif
-
 } // namespace detail
 } // namespace _V1
 } // namespace sycl

sycl/source/detail/platform_util.hpp

@@ -42,10 +42,6 @@ struct PlatformUtil {
   static uint32_t getMemCacheLineSize();
 
   static uint64_t getMemCacheSize();
-
-#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
-  static void prefetch(const char *Ptr, size_t NumBytes);
-#endif
 };
 
 } // namespace detail