Skip to content

Commit 3d7997f

Browse files
committed
Consolidate TODO for multi-device device_memory
This isn't part of the USM_LEVEL_NONE integration
1 parent 05a7f14 commit 3d7997f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

sycl/include/syclcompat/memory.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1480,6 +1480,8 @@ template <class T, memory_region Memory> class accessor<T, Memory, 2> {
14801480
};
14811481

14821482
/// Device variable with address space of shared or global.
1483+
// TODO(syclcompat-lib-reviewers): This doesn't yet support multi-device (ptr
1484+
// per device)
14831485
template <class T, memory_region Memory, size_t Dimension> class device_memory {
14841486
public:
14851487
using accessor_t =
@@ -1626,7 +1628,6 @@ template <class T, memory_region Memory, size_t Dimension> class device_memory {
16261628
_device_ptr(memory_ptr), _q(q) {}
16271629

16281630
void allocate_device(sycl::queue q) {
1629-
// TODO(joe): _q = q; here..., and in dpct this fn returns the ptr
16301631
#ifndef COMPAT_USM_LEVEL_NONE
16311632
if (Memory == memory_region::usm_shared) {
16321633
_device_ptr = (value_t *)sycl::malloc_shared(_size, q.get_device(),
@@ -1649,7 +1650,7 @@ template <class T, memory_region Memory, size_t Dimension> class device_memory {
16491650
sycl::range<Dimension> _range;
16501651
bool _reference;
16511652
value_t *_host_ptr;
1652-
value_t *_device_ptr; // TODO(joe) in dpct this is a vector<value_t*>
1653+
value_t *_device_ptr;
16531654
sycl::queue _q;
16541655
};
16551656
template <class T, memory_region Memory>

0 commit comments

Comments
 (0)