Skip to content

Commit 3f12ef2

Browse files
committed
attempt fix
Signed-off-by: Sarnie, Nick <[email protected]>
1 parent d057e2d commit 3f12ef2

File tree

4 files changed

+6
-28
lines changed

4 files changed

+6
-28
lines changed

.github/workflows/sycl-linux-build.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@ jobs:
109109
build:
110110
name: Build + LIT
111111
runs-on: [Linux, build]
112-
defaults:
113-
run:
114-
shell: bash
115112
container:
116113
image: ${{ inputs.build_image }}
117114
options: -u 1001:1001
@@ -162,15 +159,14 @@ jobs:
162159
env:
163160
CC: ${{ inputs.cc }}
164161
CXX: ${{ inputs.cxx }}
165-
ARGS: ${{ inputs.build_configure_extra_args }}
166162
CUDA_LIB_PATH: "/usr/local/cuda/lib64/stubs"
167163
run: |
168164
mkdir -p $CCACHE_DIR
169165
mkdir -p $GITHUB_WORKSPACE/build
170166
cd $GITHUB_WORKSPACE/build
171167
python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \
172168
-s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \
173-
--ci-defaults $ARGS \
169+
--ci-defaults ${{ inputs.build_configure_extra_args }} \
174170
--cmake-opt=-DCMAKE_C_COMPILER_LAUNCHER=ccache \
175171
--cmake-opt=-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
176172
--cmake-opt="-DLLVM_INSTALL_UTILS=ON" \
@@ -182,9 +178,6 @@ jobs:
182178
- name: check-llvm
183179
if: always() && !cancelled() && contains(inputs.changes, 'llvm')
184180
run: |
185-
if [[ ${{ inputs.cc }} == 'icx' ]] || [[ ${{ inputs.cxx }} == 'icpx' ]]; then
186-
export LIT_FILTER="SYCL"
187-
fi
188181
cmake --build $GITHUB_WORKSPACE/build --target check-llvm
189182
- name: check-clang
190183
if: always() && !cancelled() && contains(inputs.changes, 'clang')
@@ -197,9 +190,6 @@ jobs:
197190
run: |
198191
# TODO consider moving this to Dockerfile.
199192
export LD_LIBRARY_PATH=/usr/local/cuda/compat/:/usr/local/cuda/lib64:$LD_LIBRARY_PATH
200-
if [[ ${{ inputs.cc }} == 'icx' ]] || [[ ${{ inputs.cxx }} == 'icpx' ]]; then
201-
export LIT_XFAIL="regression/host_tanpi_double_accuracy.cpp"
202-
fi
203193
cmake --build $GITHUB_WORKSPACE/build --target check-sycl
204194
- name: check-sycl-unittests
205195
if: always() && !cancelled() && contains(inputs.changes, 'sycl')

.github/workflows/sycl-linux-run-tests.yml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ on:
8686
reset_intel_gpu:
8787
type: string
8888
required: False
89-
is_icx:
89+
use_oneapi:
9090
type: string
9191
default: 'false'
9292
install_igc_driver:
@@ -246,12 +246,8 @@ jobs:
246246
# If libllvm14 is already installed (dev igc docker), still return true.
247247
sudo apt-get install -yqq libllvm14 || true;
248248
fi
249-
sudo -E bash devops/scripts/install_drivers.sh llvm/devops/dependencies.json ${{ inputs.install_dev_igc_driver == 'true' && 'llvm/devops/dependencies-igc-dev.json --use-dev-igc' || '' }} --all
250-
- name: Setup oneAPI env
251-
if: ${{ inputs.is_icx == 'true' }}
252-
uses: ./devops/actions/setup_linux_oneapi_env
249+
sudo -E bash devops/scripts/install_drivers.sh llvm/devops/dependencies.json ${{ inputs.install_dev_igc_driver == 'true' && 'llvm/devops/dependencies-igc-dev.json --use-dev-igc' || '' }} --all
253250
- name: Source OneAPI TBB vars.sh
254-
if: ${{ inputs.is_icx == 'false' }}
255251
shell: bash
256252
run: |
257253
# https://github.com/actions/runner/issues/1964 prevents us from using
@@ -353,20 +349,12 @@ jobs:
353349
env:
354350
LIT_OPTS: -v --no-progress-bar --show-unsupported --show-pass --show-xfail --max-time 3600 --time-tests --param test-mode=${{ inputs.e2e_testing_mode }} --param sycl_devices=${{ inputs.target_devices }} ${{ inputs.extra_lit_opts }}
355351
run: |
356-
# When building with oneAPI, the oneAPI libsycl is found before the newly compiled one and the search order
357-
# can't be changed by environment variables, so just rename it temporarily.
358-
if [ ${{ inputs.is_icx }} == 'true' ]; then
359-
sudo mv /opt/intel/oneapi/compiler/2025.0/lib/libsycl.so /opt/intel/oneapi/compiler/2025.0/lib/libsycl.so.bak
360-
fi
361352
ninja -C build-e2e check-sycl-e2e > e2e.log 2>&1
362353
exit_code=$?
363354
cat e2e.log
364355
if [ $exit_code -ne 0 ]; then
365356
awk '/^Failed Tests|Unexpectedly Passed Tests|Unresolved tests|Testing Time/{flag=1}/FAILED: CMakeFiles/{flag=0}flag' e2e.log >> $GITHUB_STEP_SUMMARY
366357
fi
367-
if [ ${{ inputs.is_icx }} == 'true' ]; then
368-
sudo mv /opt/intel/oneapi/compiler/2025.0/lib/libsycl.so.bak /opt/intel/oneapi/compiler/2025.0/lib/libsycl.so
369-
fi
370358
exit $exit_code
371359
- name: Build SYCL CTS tests
372360
if: inputs.tests_selector == 'cts' && inputs.sycl_cts_artifact == ''

.github/workflows/sycl-nightly.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
build_cache_root: "/__w/"
4646
build_cache_suffix: oneapi
4747
build_artifact_suffix: oneapi
48-
build_configure_extra_args: '--hip --cuda --native_cpu --cmake-opt=-DCOMPILER_RT_BUILD_SANITIZERS=Off --cmake-opt=-DCOMPILER_RT_BUILD_MEMPROF=Off'
48+
build_configure_extra_args: --cmake-opt=-DCMAKE_C_FLAGS="-no-intel-lib -ffp-model=precise" --cmake-opt=-DCMAKE_CXX_FLAGS="-no-intel-lib -ffp-model=precise" --cmake-opt=-DCOMPILER_RT_BUILD_SANITIZERS=Off --cmake-opt=-DCOMPILER_RT_BUILD_MEMPROF=Off
4949
cc: icx
5050
cxx: icpx
5151

@@ -124,7 +124,7 @@ jobs:
124124
with:
125125
name: Intel PVC L0 oneAPI
126126
runner: '["Linux", "pvc"]'
127-
is_icx: true
127+
use_oneapi: true
128128
target_devices: level_zero:gpu
129129
extra_lit_opts: -j 50
130130
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:latest

devops/actions/setup_linux_oneapi_env/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ runs:
1919
changed_envvars=$(comm -13 <(echo "$env_before") <(echo "$env_after"))
2020
while IFS= read -r line; do
2121
echo "$line" >> $GITHUB_ENV
22-
done <<< "$changed_envvars"
22+
done <<< "$changed_envvars"

0 commit comments

Comments
 (0)