bug fixes

Author: ianayl

devops/actions/run-tests/benchmark/action.yml

@@ -60,7 +60,7 @@ runs:
       git commit -m "[GHA] Upload compute-benchmarks results from https://github.com/intel/llvm/actions/runs/${{ github.run_id }}"
       git push "https://[email protected]/$PERF_RES_GIT_REPO.git" "$PERF_RES_BRANCH"
   - name: Archive compute-benchmark results
-    if: inputs.tests_selector == 'benchmark' && always()
+    if: always()
     uses: actions/upload-artifact@v4
     with:
       name: Compute-benchmark results (${{ runner.name }})

devops/scripts/benchmarking/benchmark.sh

@@ -22,14 +22,14 @@ This script builds and runs benchmarks from compute-benchmarks."
 
 clone_perf_res() {
     echo "### Cloning llvm-ci-perf-res ($PERF_RES_GIT_REPO:$PERF_RES_BRANCH) ###"
-    mkdir -p "$(dirname $PERF_RES_PATH)"
+    mkdir -p "$(dirname "$PERF_RES_PATH")"
     git clone -b $PERF_RES_BRANCH https://github.com/$PERF_RES_GIT_REPO $PERF_RES_PATH
     [ "$?" -ne 0 ] && exit $? 
 }
 
 clone_compute_bench() {
     echo "### Cloning compute-benchmarks ($COMPUTE_BENCH_GIT_REPO:$COMPUTE_BENCH_BRANCH) ###"
-    mkdir -p "$(dirname $COMPUTE_BENCH_PATH)"
+    mkdir -p "$(dirname "$COMPUTE_BENCH_PATH")"
     git clone -b $COMPUTE_BENCH_BRANCH \
               --recurse-submodules https://github.com/$COMPUTE_BENCH_GIT_REPO \
               $COMPUTE_BENCH_PATH
@@ -98,8 +98,8 @@ samples_under_threshold () {
 #
 # Usage: check_regression <relative path of output csv>
 check_regression() {
-    csv_relpath="$(dirname $1)"
-    csv_name="$(basename $1)"
+    csv_relpath="$(dirname "$1")"
+    csv_name="$(basename "$1")"
     if samples_under_threshold "$csv_relpath"; then
         echo "Not enough samples to construct a good average, performance\
  check skipped!"
@@ -145,7 +145,7 @@ process_benchmarks() {
         exit 1
     else
         rm "$BENCHMARK_ERROR_LOG" "$BENCHMARK_SLOW_LOG" 2> /dev/null
-        mkdir -p "$(dirname $BENCHMARK_ERROR_LOG)" "$(dirname $BENCHMARK_SLOW_LOG)"
+        mkdir -p "$(dirname "$BENCHMARK_ERROR_LOG")" "$(dirname "$BENCHMARK_SLOW_LOG")"
         # Loop through each line of enabled_tests.conf, but ignore lines in the
         # test config starting with #'s:
         grep "^[^#]" "$TESTS_CONFIG" | while read -r testcase; do
@@ -216,7 +216,7 @@ load_configs() {
     # If this is not provided, this function tries to guess where the files
     # are based on how the script is called, and verifies that all necessary
     # configs and scripts are reachable. 
-    [ -z "$BENCHMARKING_ROOT" ] && BENCHMARKING_ROOT="$(dirname $0)"
+    [ -z "$BENCHMARKING_ROOT" ] && BENCHMARKING_ROOT="$(dirname "$0")"
 
     BENCHMARK_CI_CONFIG="$(realpath $BENCHMARKING_ROOT/benchmark-ci.conf)"
     TESTS_CONFIG="$(realpath $BENCHMARKING_ROOT/enabled_tests.conf)"

devops/scripts/benchmarking/common.py

@@ -49,7 +49,7 @@ def load_configs():
         for perf_res in perf_res_re.findall(configs_str):
             PERF_RES_PATH = str(perf_res[1:-1])
 
-        for output_cache in output_path_re.findall(configs_str):
+        for output_cache in output_cache_re.findall(configs_str):
             OUTPUT_CACHE = str(output_cache[1:-1])
 
         for b_slow_log in b_slow_re.findall(configs_str):