Skip to content

Commit 42b2d97

Browse files
[Bench] Clean up regression printing info in compare.py
1 parent ed3809b commit 42b2d97

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

devops/scripts/benchmarks/compare.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ def print_regression(entry: dict, is_warning: bool = False):
411411
log_func(f"-- Delta: {entry['delta']}")
412412
log_func("")
413413
if args.produce_github_summary:
414-
gh_summary.append(f"#### {entry['name']}:")
414+
gh_summary.append(f"##### {entry['name']}:")
415415
gh_summary.append(
416416
f"- Historic {entry['avg_type']}: {entry['hist_avg']}"
417417
)
@@ -427,12 +427,16 @@ def print_regression(entry: dict, is_warning: bool = False):
427427
)
428428
gh_summary.append("")
429429

430+
if args.produce_github_summary:
431+
gh_summary.append("")
432+
gh_summary.append("### Regressions and Improvements")
433+
430434
if improvements:
431435
log.info("#")
432436
log.info("# Improvements:")
433437
log.info("#")
434438
if args.produce_github_summary:
435-
gh_summary.append(f"### Improvements")
439+
gh_summary.append(f"#### Improvements")
436440
gh_summary.append(
437441
f"<details><summary>{len(improvements)} improved tests:</summary>"
438442
)
@@ -444,12 +448,16 @@ def print_regression(entry: dict, is_warning: bool = False):
444448
gh_summary.append("")
445449
if regressions_ignored:
446450
log.info("#")
447-
log.info("# Regressions (filtered out by --regression-filter):")
451+
log.info(
452+
f"# Regressions Ignored (filtered out by --regression-filter: {filter_type_capitalized})"
453+
)
448454
log.info("#")
449455
if args.produce_github_summary:
450-
gh_summary.append(f"### Non-{filter_type_capitalized} Regressions")
451456
gh_summary.append(
452-
f"<details><summary>{len(regressions_ignored)} non-{args.regression_filter_type} regressions:</summary>"
457+
f"#### Regressions Ignored (filtered out by --regression-filter: {filter_type_capitalized})"
458+
)
459+
gh_summary.append(
460+
f"<details><summary>{len(regressions_ignored)} non-'{args.regression_filter_type}' regressions:</summary>"
453461
)
454462
gh_summary.append("")
455463
for test in regressions_ignored:
@@ -462,7 +470,7 @@ def print_regression(entry: dict, is_warning: bool = False):
462470
log.warning("# Regressions:")
463471
log.warning("#")
464472
if args.produce_github_summary:
465-
gh_summary.append(f"### {filter_type_capitalized} Regressions")
473+
gh_summary.append(f"#### {filter_type_capitalized} Regressions")
466474
gh_summary.append(
467475
f"{len(regressions_of_concern)} {args.regression_filter_type} regressions. These regressions warrant a CI failure:"
468476
)
@@ -480,8 +488,6 @@ def print_regression(entry: dict, is_warning: bool = False):
480488

481489
log.info("No unexpected regressions found!")
482490
if args.produce_github_summary:
483-
gh_summary.append("")
484-
gh_summary.append("### Regressions")
485491
gh_summary.append("No unexpected regressions found!")
486492
with open(options.github_summary_regression_filename, "w") as f:
487493
f.write("\n".join(gh_summary))

0 commit comments

Comments
 (0)