Formatting and remove warnings

Author: lbushi25

clang/lib/Sema/SemaSYCL.cpp

@@ -227,7 +227,7 @@ local_accessor: public accessor<dataT,
         access::target::local> {
 public:
 #ifdef __SYCL_DEVICE_ONLY__
-local_accessor() = default;
+  local_accessor() = default;
 #endif
   void use(void) const {}
   template <typename... T>
@@ -252,11 +252,13 @@ struct sampler_impl {
 class __attribute__((sycl_special_class)) __SYCL_TYPE(sampler) sampler {
   struct sampler_impl impl;
 #ifdef __SYCL_DEVICE_ONLY__
-sampler() = default;
   void __init(__ocl_sampler_t Sampler) { impl.m_Sampler = Sampler; }
 #endif
 
 public:
+#ifdef __SYCL_DEVICE_ONLY__
+  sampler() = default;
+#endif
   void use(void) const {}
 };
 
@@ -489,19 +491,21 @@ namespace experimental {
 template <typename T, typename... Props>
 class __attribute__((sycl_special_class)) __SYCL_TYPE(annotated_arg) annotated_arg {
   T obj;
-  #ifdef __SYCL_DEVICE_ONLY__
-annotated_arg() = default;
-    void __init(T _obj) {}
-  #endif
+#ifdef __SYCL_DEVICE_ONLY__
+  void __init(T _obj) {}
+public:
+  annotated_arg() = default;
+#endif
 };
 
 template <typename T, typename... Props>
 class __attribute__((sycl_special_class)) __SYCL_TYPE(annotated_ptr) annotated_ptr {
   T* obj;
-  #ifdef __SYCL_DEVICE_ONLY__
-    annotated_ptr() = default;
-    void __init(T* _obj) {}
-  #endif
+#ifdef __SYCL_DEVICE_ONLY__
+  void __init(T* _obj) {}
+public:
+  annotated_ptr() = default;   
+#endif
 };
 
 } // namespace experimental

clang/test/SemaSYCL/Inputs/sycl.hpp

@@ -20,15 +20,15 @@ inline namespace _V1 {
 namespace access {
 
 enum class target {
-  global_buffer __SYCL2020_DEPRECATED("use 'target::device' instead") = 2014,
+  device = 2014,
+  global_buffer __SYCL2020_DEPRECATED("use 'target::device' instead") = device,
   constant_buffer __SYCL2020_DEPRECATED("use 'target::device' instead") = 2015,
   local __SYCL2020_DEPRECATED("use `local_accessor` instead") = 2016,
   image = 2017,
   host_buffer __SYCL2020_DEPRECATED("use 'host_accessor' instead") = 2018,
   host_image = 2019,
   image_array = 2020,
   host_task = 2021,
-  device = global_buffer,
 };
 
 enum class mode {

sycl/include/sycl/access/access.hpp

@@ -221,9 +221,9 @@ class AccessorPrivateProxy;
 } // namespace ext::intel::esimd::detail
 
 template <typename DataT, int Dimensions = 1,
-          access::mode AccessMode = sycl::access::mode::read_write,
-          access::target AccessTarget = sycl::access::target::device,
-          access::placeholder IsPlaceholder = sycl::access::placeholder::false_t,
+          access::mode AccessMode = access::mode::read_write,
+          access::target AccessTarget = access::target::device,
+          access::placeholder IsPlaceholder = access::placeholder::false_t,
           typename PropertyListT = ext::oneapi::accessor_property_list<>>
 class accessor;
 

sycl/include/sycl/accessor.hpp

@@ -520,8 +520,7 @@ class __SYCL_EXPORT handler {
 
   /// Saves the location of user's code passed in \p CodeLoc for future usage in
   /// finalize() method.
-  /// TODO: remove the first version of this func (the one without the
-  /// IsTopCodeLoc arg)
+  /// TODO: remove the first version of this func (the one without the IsTopCodeLoc arg)  
   ///   at the next ABI breaking window since removing it breaks ABI on windows.
   void saveCodeLoc(detail::code_location CodeLoc);
   void saveCodeLoc(detail::code_location CodeLoc, bool IsTopCodeLoc);

sycl/include/sycl/handler.hpp

@@ -59,7 +59,7 @@ template <typename KernelName> kernel_id get_kernel_id();
 
 namespace ext::oneapi::experimental {
 template <auto *Func>
-kernel_id get_kernel_id();
+std::enable_if_t<is_kernel_v<Func>, kernel_id> get_kernel_id();
 } // namespace ext::oneapi::experimental
 
 /// Objects of the class identify kernel is some kernel_bundle related APIs

sycl/include/sycl/kernel_bundle.hpp

@@ -3511,6 +3511,7 @@ _ZN4sycl3_V17handler11storeRawArgEPKvm
 _ZN4sycl3_V17handler12addReductionERKSt10shared_ptrIKvE
 _ZN4sycl3_V17handler12setArgHelperEiRNS0_3ext6oneapi12experimental6detail30dynamic_work_group_memory_baseE
 _ZN4sycl3_V17handler12setArgHelperEiRNS0_6detail22work_group_memory_implE
+_ZN4sycl3_V17handler12setArgHelperEiONS0_6streamE
 _ZN4sycl3_V17handler13getKernelNameEv
 _ZN4sycl3_V17handler14addAccessorReqESt10shared_ptrINS0_6detail16AccessorImplHostEE
 _ZN4sycl3_V17handler14setNDRangeUsedEb

sycl/test/abi/sycl_symbols_linux.dump

@@ -4346,6 +4346,7 @@
 ?select_device@filter_selector@oneapi@ext@_V1@sycl@@UEBA?AVdevice@45@XZ
 ?setArgHelper@handler@_V1@sycl@@AEAAXH$$QEAVraw_kernel_arg@experimental@oneapi@ext@23@@Z
 ?setArgHelper@handler@_V1@sycl@@AEAAXH$$QEAVsampler@23@@Z
+?setArgHelper@handler@_V1@sycl@@AEAAXH$$QEAVstream@23@@Z
 ?setArgHelper@handler@_V1@sycl@@AEAAXHAEAVwork_group_memory_impl@detail@23@@Z
 ?setArgsHelper@handler@_V1@sycl@@AEAAXH@Z
 ?setArgsToAssociatedAccessors@handler@_V1@sycl@@AEAAXXZ