[SYCL] Add invalid_arg_type for function pointer after 8cc9a48 (#27942)

8cc9a48 refactored err_builtin_invalid_arg_type,
readd the function pointer type for sycl.

Author: jsji

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -12653,7 +12653,7 @@ def err_builtin_invalid_arg_type: Error<
   "%plural{0:|: }1"
   // Second component: integer-like types
   "%select{|integer|signed integer|unsigned integer|'int'|"
-  "pointer to a valid matrix element}2"
+  "pointer to a valid matrix element|function pointer}2"
   // A space after a non-empty second component
   "%plural{0:|: }2"
   // An 'or' if non-empty second and third components are combined

clang/lib/Sema/SemaChecking.cpp

@@ -3026,7 +3026,7 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
 
     if (!ArgTy->isFunctionProtoType() && !ArgTy->isFunctionPointerType()) {
       Diag(Arg->getBeginLoc(), diag::err_builtin_invalid_arg_type)
-          << 1 << /* pointer to function type */ 10 << ArgTy;
+          << 1 << 0 << /* pointer to function type */ 6 << 0 << ArgTy;
       return ExprError();
     }
 

clang/test/SemaSYCL/builtin_sycl_kernel.cpp

@@ -73,15 +73,15 @@ void foo() {
   constexpr bool b14 = __builtin_sycl_is_kernel(&sndrk_free_func1);
 
   // Test with function templates.
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b15 = __builtin_sycl_is_kernel(&sndrk_free_func_tmpl1<int>);
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b16 = __builtin_sycl_is_kernel(sndrk_free_func_tmpl1<int>);
   constexpr bool b17 = __builtin_sycl_is_kernel((void(*)(int *))sndrk_free_func_tmpl1<int>);  // Okay
 
 
   // Test with overloaded functions.
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b18 = __builtin_sycl_is_kernel(ovl_free_func1);
   constexpr bool b19 = __builtin_sycl_is_kernel((void(*)(int *))ovl_free_func1);  // Okay
   constexpr bool b20 = __builtin_sycl_is_kernel((void(*)(int *, int))ovl_free_func1);  // Okay

clang/test/SemaSYCL/builtin_sycl_nd_range_kernel.cpp

@@ -72,15 +72,15 @@ void foo() {
   constexpr bool b14 = __builtin_sycl_is_nd_range_kernel(&sndrk_free_func1, 4);  // Okay
 
   // Test with function templates.
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b15 = __builtin_sycl_is_nd_range_kernel(&sndrk_free_func_tmpl1<int>, 6);
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b16 = __builtin_sycl_is_nd_range_kernel(sndrk_free_func_tmpl1<int>, 8);
   constexpr bool b17 = __builtin_sycl_is_nd_range_kernel((void(*)(int *))sndrk_free_func_tmpl1<int>, 12);  // Okay
 
 
   // Test with overloaded functions.
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b18 = __builtin_sycl_is_nd_range_kernel(ovl_free_func1, 4);
   constexpr bool b19 = __builtin_sycl_is_nd_range_kernel((void(*)(int *))ovl_free_func1, 2);  // Okay
   constexpr bool b20 = __builtin_sycl_is_nd_range_kernel((void(*)(int *, int))ovl_free_func1, 2);  // Okay

clang/test/SemaSYCL/builtin_sycl_single_task_kernel.cpp

@@ -73,15 +73,15 @@ void foo() {
   constexpr bool b13 = __builtin_sycl_is_single_task_kernel(&sstk_free_func1);  // Okay
 
   // Test with function templates.
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b14 = __builtin_sycl_is_single_task_kernel(&sstk_free_func_tmpl1<int>);
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b15 = __builtin_sycl_is_single_task_kernel(sstk_free_func_tmpl1<int>);
   constexpr bool b16 = __builtin_sycl_is_single_task_kernel((void(*)(int *))sstk_free_func_tmpl1<int>);  // Okay
 
 
   // Test with overloaded functions.
-  // expected-error@+1 {{1st argument must be a function pointer (was '<overloaded function type>')}}
+  // expected-error@+1 {{1st argument must be a function pointer type (was '<overloaded function type>')}}
   constexpr bool b17 = __builtin_sycl_is_single_task_kernel(ovl_free_func1);
   constexpr bool b18 = __builtin_sycl_is_single_task_kernel((void(*)(int *))ovl_free_func1);  // Okay
   constexpr bool b19 = __builtin_sycl_is_single_task_kernel((void(*)(int *, int))ovl_free_func1);  // Okay