Rename checkUSMImplAlignment to isPointerAlignedTo. Change func to take single *pointer and deference at calls sites where double** was being passed.

Author: martygrant

unified-runtime/source/adapters/hip/usm.cpp

@@ -144,7 +144,7 @@ ur_result_t USMDeviceAllocImpl(void **ResultPtr, ur_context_handle_t,
     return Err;
   }
 
-  assert(checkUSMImplAlignment(Alignment, ResultPtr));
+  assert(isPointerAlignedTo(Alignment, *ResultPtr));
   return UR_RESULT_SUCCESS;
 }
 
@@ -160,7 +160,7 @@ ur_result_t USMSharedAllocImpl(void **ResultPtr, ur_context_handle_t,
     return Err;
   }
 
-  assert(checkUSMImplAlignment(Alignment, ResultPtr));
+  assert(isPointerAlignedTo(Alignment, *ResultPtr));
   return UR_RESULT_SUCCESS;
 }
 
@@ -174,7 +174,7 @@ ur_result_t USMHostAllocImpl(void **ResultPtr,
     return Err;
   }
 
-  assert(checkUSMImplAlignment(Alignment, ResultPtr));
+  assert(isPointerAlignedTo(Alignment, *ResultPtr));
   return UR_RESULT_SUCCESS;
 }
 

unified-runtime/source/adapters/opencl/usm.cpp

@@ -270,7 +270,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMFill(
   cl_context CLContext = hQueue->Context->CLContext;
 
   if (patternSize <= 128 && isPowerOf2(patternSize) &&
-      checkUSMImplAlignment(patternSize, &ptr)) {
+      isPointerAlignedTo(patternSize, ptr)) {
     clEnqueueMemFillINTEL_fn EnqueueMemFill = nullptr;
     UR_RETURN_ON_FAILURE(
         cl_ext::getExtFuncFromContext<clEnqueueMemFillINTEL_fn>(

unified-runtime/source/common/ur_util.hpp

@@ -548,9 +548,9 @@ static inline std::string groupDigits(Numeric numeric) {
 
 template <typename T> Spinlock<Rc<T>> AtomicSingleton<T>::instance;
 
-inline bool checkUSMImplAlignment(uint32_t Alignment, void **ResultPtr) {
+inline bool isPointerAlignedTo(uint32_t Alignment, void *Ptr) {
   return Alignment == 0 ||
-         reinterpret_cast<std::uintptr_t>(*ResultPtr) % Alignment == 0;
+         reinterpret_cast<std::uintptr_t>(Ptr) % Alignment == 0;
 }
 
 #endif /* UR_UTIL_H */