Skip to content

Commit 4c46a5d

Browse files
author
Peiming Liu
committed
[mlir][sparse] Refactoring: renaming StorageNewOp to StorageOp
To address comment in https://reviews.llvm.org/D133241 Reviewed By: aartbik Differential Revision: https://reviews.llvm.org/D133363
1 parent c51a12d commit 4c46a5d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@ def SparseTensor_YieldOp : SparseTensor_Op<"yield", [NoSideEffect, Terminator]>,
629629
// sparse tensor codegen to progressively lower sparse tensors.
630630
//===----------------------------------------------------------------------===//
631631

632-
def SparseTensor_StorageNewOp : SparseTensor_Op<"storage", []>,
632+
def SparseTensor_StorageOp : SparseTensor_Op<"storage", []>,
633633
Arguments<(ins Variadic<AnyType>:$inputs)>,
634634
Results<(outs AnyTuple:$result)> {
635635
let summary = "Pack a list of value into one sparse tensor storage value";

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ LogicalResult YieldOp::verify() {
486486
// Sparse Tensor Storage Operation.
487487
//===----------------------------------------------------------------------===//
488488

489-
LogicalResult StorageNewOp::verify() {
489+
LogicalResult StorageOp::verify() {
490490
auto retTypes = getResult().getType().getTypes();
491491
if (retTypes.size() != getInputs().size())
492492
return emitError("The number of inputs is inconsistent with output tuple");

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ static Value createTupleGet(OpBuilder &builder, Location loc, Value tuple,
174174
/// Creates tuple.
175175
static Value createTupleMake(OpBuilder &builder, Location loc, Type type,
176176
ValueRange values) {
177-
return builder.create<StorageNewOp>(loc, type, values);
177+
return builder.create<StorageOp>(loc, type, values);
178178
}
179179

180180
/// Create allocation operation.

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ struct SparseTensorCodegenPass
156156
ConversionTarget target(*ctx);
157157
// Almost everything in the sparse dialect must go!
158158
target.addIllegalDialect<SparseTensorDialect>();
159-
target.addLegalOp<StorageGetOp, StorageSetOp, StorageNewOp>();
159+
target.addLegalOp<StorageGetOp, StorageSetOp, StorageOp>();
160160
// All dynamic rules below accept new function, call, return, and various
161161
// tensor and bufferization operations as legal output of the rewriting
162162
// provided that all sparse tensor types have been fully rewritten.

0 commit comments

Comments
 (0)