[SYCL][NFC] Drop confusing std::moves (#20483)

This is similar to #20455 - there is a bunch of places where
we call `std::move(const obj &)`, but target classes do not provide
`obj(const &&)` move constructors, falling back to regular `obj(const
&)` copy constructor, thus making the `std::move` useless and confusing.

This should also help clean up the Coverity scan
(https://scan.coverity.com/projects/intel-llvm?tab=overview), see CIDs
`535398`, `535480`, `535420` and `535554`. By some reason Coverity
thinks that we are using a moved object, whilst in fact no moves were
performed, only copies.

Author: AlexeySachkov

sycl/source/detail/device_image_impl.hpp

@@ -296,7 +296,7 @@ class device_image_impl
       KernelNameSetT &&KernelNames,
       KernelNameToArgMaskMap &&EliminatedKernelArgMasks,
       std::unique_ptr<DynRTDeviceBinaryImage> &&MergedImageStorage, private_tag)
-      : MBinImage(BinImage), MContext(std::move(Context)),
+      : MBinImage(BinImage), MContext(Context),
         MDevices(Devices.to<std::vector<device_impl *>>()), MState(State),
         MProgram(std::move(Program)), MKernelIDs(std::move(KernelIDs)),
         MKernelNames{std::move(KernelNames)},
@@ -315,7 +315,7 @@ class device_image_impl
       MangledKernelNameMapT &&MangledKernelNames, std::string &&Prefix,
       std::shared_ptr<ManagedDeviceGlobalsRegistry> &&DeviceGlobalRegistry,
       private_tag)
-      : MBinImage(BinImage), MContext(std::move(Context)),
+      : MBinImage(BinImage), MContext(Context),
         MDevices(Devices.to<std::vector<device_impl *>>()), MState(State),
         MKernelIDs(std::move(KernelIDs)), MKernelNames{std::move(KernelNames)},
         MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
@@ -329,7 +329,7 @@ class device_image_impl
   device_image_impl(const std::string &Src, context Context,
                     devices_range Devices, syclex::source_language Lang,
                     include_pairs_t &&IncludePairsVec, private_tag)
-      : MBinImage(Src), MContext(std::move(Context)),
+      : MBinImage(Src), MContext(Context),
         MDevices(Devices.to<std::vector<device_impl *>>()),
         MState(bundle_state::ext_oneapi_source),
         MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
@@ -342,7 +342,7 @@ class device_image_impl
   device_image_impl(const std::vector<std::byte> &Bytes, const context &Context,
                     devices_range Devices, syclex::source_language Lang,
                     private_tag)
-      : MBinImage(Bytes), MContext(std::move(Context)),
+      : MBinImage(Bytes), MContext(Context),
         MDevices(Devices.to<std::vector<device_impl *>>()),
         MState(bundle_state::ext_oneapi_source),
         MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
@@ -356,9 +356,9 @@ class device_image_impl
                     syclex::source_language Lang, KernelNameSetT &&KernelNames,
                     private_tag)
       : MBinImage(static_cast<const RTDeviceBinaryImage *>(nullptr)),
-        MContext(std::move(Context)),
-        MDevices(Devices.to<std::vector<device_impl *>>()), MState(State),
-        MProgram(std::move(Program)), MKernelNames{std::move(KernelNames)},
+        MContext(Context), MDevices(Devices.to<std::vector<device_impl *>>()),
+        MState(State), MProgram(std::move(Program)),
+        MKernelNames{std::move(KernelNames)},
         MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
         MOrigins(ImageOriginKernelCompiler),
         MRTCBinInfo(KernelCompilerBinaryInfo{Lang}) {}

sycl/source/detail/scheduler/commands.cpp

@@ -1511,8 +1511,8 @@ MemCpyCommand::MemCpyCommand(const Requirement &SrcReq,
                              queue_impl *SrcQueue, queue_impl *DstQueue)
     : Command(CommandType::COPY_MEMORY, DstQueue),
       MSrcQueue(SrcQueue ? SrcQueue->shared_from_this() : nullptr),
-      MSrcReq(std::move(SrcReq)), MSrcAllocaCmd(SrcAllocaCmd),
-      MDstReq(std::move(DstReq)), MDstAllocaCmd(DstAllocaCmd) {
+      MSrcReq(SrcReq), MSrcAllocaCmd(SrcAllocaCmd), MDstReq(DstReq),
+      MDstAllocaCmd(DstAllocaCmd) {
   if (MSrcQueue) {
     MEvent->setContextImpl(MSrcQueue->getContextImpl());
   }