Skip to content

Commit 51cb464

Browse files
committed
Always run tests with lit internal shell
1 parent dadc1d3 commit 51cb464

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

sycl/test-e2e/format.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -373,15 +373,12 @@ def get_extra_env(sycl_devices):
373373
conditions,
374374
recursion_limit=test.config.recursiveExpansionLimit,
375375
)
376-
377-
# TODO: workaround for lit hanging when executing non-existent binary
378-
# inside our containers
379376
if len(script) == 0:
380377
return lit.Test.Result(lit.Test.UNSUPPORTED, "Lit script is empty")
381-
useExternalSh = test.config.test_mode == "run-only"
382378

379+
# FIXME: will hang if trying to execute non-existant binary in our containers
383380
result = lit.TestRunner._runShTest(
384-
test, litConfig, useExternalSh, script, tmpBase
381+
test, litConfig, False, script, tmpBase
385382
)
386383

387384
# Single triple/device - might be an XFAIL.

0 commit comments

Comments
 (0)