Skip to content

Commit 55d339c

Browse files
committed
Changes to comments
1 parent 5a8cbe6 commit 55d339c

File tree

3 files changed

+11
-24
lines changed

3 files changed

+11
-24
lines changed

devops/benchmarking/config.ini

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
; benchmarking workflow in sycl-linux-run-tests.yml.
44
;
55
; DO NOT USE THE CONTENTS OF THIS FILE DIRECTLY -- Due to security concerns, The
6-
; contents of this file must be sanitized first before use. See: xxx.py
6+
; contents of this file must be sanitized first before use.
7+
; See: /devops/scripts/benchmarking/common.py
78
;
89

910
; Compute-benchmark compile/run options

devops/benchmarking/constants.ini

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
; workflow, you're likely looking for /devops/benchmarking/config.ini instead.
55
;
66
; DO NOT USE THE CONTENTS OF THIS FILE DIRECTLY -- Due to security concerns, The
7-
; contents of this file must be sanitized first before use. See: xxx.py
7+
; contents of this file must be sanitized first before use.
8+
; See: /devops/scripts/benchmarking/common.py
89
;
910

1011
; Constants for compute-benchmarks
@@ -14,6 +15,13 @@ git_branch = master
1415
git_commit = 230a3db4d8d03c0e9a663988f7c3abbd1137a1e0
1516
; path = ./compute-benchmarks
1617

18+
; Constants for git repo storing benchmark performance results
19+
[perf_res]
20+
git_repo = intel/llvm-ci-perf-results
21+
git_branch = main
22+
; Path to clone performance result repo
23+
; path = ./llvm-ci-perf-results
24+
1725
; It was decided that paths should be hardcoded throughout this workflow for
1826
; security reasons and ease of readability. Do not use paths as constants.
1927

@@ -29,13 +37,6 @@ git_commit = 230a3db4d8d03c0e9a663988f7c3abbd1137a1e0
2937
; ; Path (relative to artifact.path) to cache passing compute-benchmark results
3038
; passing_cache = ./artifact/passing_tests
3139

32-
; Constants for git repo storing benchmark performance results
33-
[perf_res]
34-
git_repo = intel/llvm-ci-perf-results
35-
git_branch = main
36-
; Path to clone performance result repo
37-
; path = ./llvm-ci-perf-results
38-
3940
; [timestamp]
4041
; ; Timestamp format used for
4142
; format = %%Y%%m%%d_%%H%%M%%S

devops/scripts/benchmarking/common.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -163,21 +163,6 @@ def export_python_globals(self):
163163
all_opts.read(self.config_path)
164164
all_opts.read(self.constants_path)
165165

166-
# It was decided that paths should be hardcoded throughout this workflow
167-
# for security reasons and ease of readability purposes:
168-
169-
# SanitizedConfig.PERF_RES_PATH = \
170-
# self.__sanitize(all_opts["perf_res"]["path"], "perf_res.path")
171-
# SanitizedConfig.ARTIFACT_OUTPUT_CACHE = \
172-
# self.__sanitize(all_opts["artifact"]["output_cache"],
173-
# "artifact.output_cache")
174-
# SanitizedConfig.BENCHMARK_LOG_SLOW = \
175-
# self.__sanitize(all_opts["benchmark_log"]["slow"],
176-
# "benchmark_log.slow")
177-
# SanitizedConfig.BENCHMARK_LOG_ERROR = \
178-
# self.__sanitize(all_opts["benchmark_log"]["error"],
179-
# "benchmark_log.error")
180-
181166
# Fields that are supposed to be python objects need to be changed to
182167
# python objects manually:
183168

0 commit comments

Comments
 (0)