You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SYCL] Disable fast math in math_ops and marray_common tests (#15223)
We've seen those tests failing when release testing. It boils down to
the fact that `icpx` will by default (with no user input) enable fast
math mode.
* `marray_common.cpp` - uses golden values alongside allowed delta,
however in fast math mode the calculation error is greater than the
delta
* `math_ops.cpp` - uses `isnan`, which compilers are not obliged to
honour in fast math mode.
If nothing else, those tests are a perfect example of how forcing fast
math mode on can cause non-obvious errors in, otherwise sound, user code
when floating point types are being used.
0 commit comments