Skip to content

Commit 5ef79d2

Browse files
author
Fábio Mestre
committed
Address review comments
1 parent 907e934 commit 5ef79d2

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

sycl/doc/design/CommandGraph.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -343,19 +343,21 @@ version:
343343

344344
- Immediate Append path - Relies on
345345
[zeCommandListImmediateAppendCommandListsExp](https://oneapi-src.github.io/level-zero-spec/level-zero/latest/core/api.html#zecommandlistimmediateappendcommandlistsexp)
346-
to submit the command-buffer.
346+
to submit the command-buffer. This function is an experimental extension to the level-zero API.
347347
- Wait event path - Relies on
348348
[zeCommandQueueExecuteCommandLists](https://oneapi-src.github.io/level-zero-spec/level-zero/latest/core/api.html#zecommandqueueexecutecommandlists)
349349
to submit the command-buffer work. However, this level-zero function has
350350
limitations and, as such, this path is used only when the immediate append
351351
path is unavailable.
352352

353-
#### Immediate Append Path implementation details
353+
#### Immediate Append Path Implementation Details
354354

355355
This path is only available when the device supports immediate command-lists
356356
and the [zeCommandListImmediateAppendCommandListsExp](https://oneapi-src.github.io/level-zero-spec/level-zero/latest/core/api.html#zecommandlistimmediateappendcommandlistsexp)
357-
API. This API has a `phWaitEvents` argument which allows for a cleaner and more efficient
358-
implementation than what can be achieved when using the wait-event path
357+
API. This API can wait on a list of event dependencies using the `phWaitEvents`
358+
parameter and can signal a return event when finished using the `hSignalEvent`
359+
parameter. This allows for a cleaner and more efficient implementation than
360+
what can be achieved when using the wait-event path
359361
(see [this section](#wait-event-path-implementation-details-) for
360362
more details about the wait-event path).
361363

@@ -390,7 +392,7 @@ we need 2 of these helper command-lists:
390392
- The `ZeCopyEngineImmediateListHelper` command-list is used to submit the
391393
`CopyCommandList`
392394

393-
#### Wait event path implementation details
395+
#### Wait event Path Implementation Details
394396
The UR `urCommandBufferEnqueueExp` interface for submitting a command-buffer
395397
takes a list of events to wait on, and returns an event representing the
396398
completion of that specific submission of the command-buffer.

0 commit comments

Comments
 (0)