Skip to content

Commit 5f05650

Browse files
[SYCL][CI] Use -D_FORTIFY_SOURCE=2 in Nightly E2E CI
See #1117 and #11436 for the context. In this mode, `std::memcpy` cannot be used in device code, but its usage occasionally leaks into our code base. I think testing the configuration in CI is the easiest way to prevent that with at least some confidence. Another option would be to modify FE to report any usage of `std::memcpy` in device code only, but I don't know if that's even possible.
1 parent 2824f61 commit 5f05650

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/sycl-nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
image_options: ${{ matrix.image_options }}
111111
target_devices: ${{ matrix.target_devices }}
112112
tests_selector: ${{ matrix.tests_selector }}
113-
extra_lit_opts: "--param 'cxx_flags=-D_GLIBCXX_USE_CXX11_ABI=0' ${{ matrix.extra_lit_opts }}"
113+
extra_lit_opts: "--param 'cxx_flags=-D_GLIBCXX_USE_CXX11_ABI=0 -D_FORTIFY_SOURCE=2' ${{ matrix.extra_lit_opts }}"
114114
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
115115
ref: ${{ github.sha }}
116116
merge_ref: ''

0 commit comments

Comments
 (0)