Skip to content

Commit 6586e3b

Browse files
committed
Fix formatting and var name
1 parent 8b64be9 commit 6586e3b

File tree

2 files changed

+34
-30
lines changed

2 files changed

+34
-30
lines changed

sycl/unittests/helpers/CommandSubmitWrappers.hpp

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,26 @@
1111

1212
using namespace sycl;
1313

14-
template<typename KernelName, typename KernelType>
15-
event single_task_wrapper(bool Shortcut, queue &Q, const KernelType &KernelFunc) {
16-
if (Shortcut) {
17-
return Q.single_task<KernelName>(KernelFunc);
18-
} else {
19-
return Q.submit([&](handler &cgh) { cgh.single_task<KernelName>(KernelFunc); });
20-
}
14+
template <typename KernelName, typename KernelType>
15+
event single_task_wrapper(bool ShortcutSubmitFunction, queue &Q,
16+
const KernelType &KernelFunc) {
17+
if (ShortcutSubmitFunction) {
18+
return Q.single_task<KernelName>(KernelFunc);
19+
} else {
20+
return Q.submit(
21+
[&](handler &cgh) { cgh.single_task<KernelName>(KernelFunc); });
22+
}
2123
}
2224

23-
template<typename KernelName, typename KernelType>
24-
event single_task_wrapper(bool Shortcut, queue &Q, event DepEvent, const KernelType &KernelFunc) {
25-
if (Shortcut) {
26-
return Q.single_task<KernelName>(DepEvent, KernelFunc);
27-
} else {
28-
return Q.submit([&](handler &cgh) {
29-
cgh.depends_on(DepEvent);
30-
cgh.single_task<KernelName>(KernelFunc);
31-
});
32-
}
25+
template <typename KernelName, typename KernelType>
26+
event single_task_wrapper(bool ShortcutSubmitFunction, queue &Q, event DepEvent,
27+
const KernelType &KernelFunc) {
28+
if (ShortcutSubmitFunction) {
29+
return Q.single_task<KernelName>(DepEvent, KernelFunc);
30+
} else {
31+
return Q.submit([&](handler &cgh) {
32+
cgh.depends_on(DepEvent);
33+
cgh.single_task<KernelName>(KernelFunc);
34+
});
35+
}
3336
}

sycl/unittests/scheduler/InOrderQueueDeps.cpp

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
#include "SchedulerTest.hpp"
1010
#include "SchedulerTestUtils.hpp"
1111

12+
#include <helpers/CommandSubmitWrappers.hpp>
1213
#include <helpers/TestKernel.hpp>
1314
#include <helpers/UrMock.hpp>
14-
#include <helpers/CommandSubmitWrappers.hpp>
1515
#include <sycl/usm.hpp>
1616

1717
#include <iostream>
@@ -110,17 +110,17 @@ TEST_P(SchedulerTest, InOrderQueueIsolatedDeps) {
110110
context Ctx{Plt.get_devices()[0]};
111111
queue Q1{Ctx, default_selector_v, property::queue::in_order()};
112112
{
113-
event E = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
114-
Q1, []() {});
113+
event E =
114+
single_task_wrapper<TestKernel>(ShortcutSubmitFunction, Q1, []() {});
115115
Q1.ext_oneapi_submit_barrier({E});
116116
EXPECT_FALSE(BarrierCalled);
117117
}
118118
queue Q2{Ctx, default_selector_v, property::queue::in_order()};
119119
{
120-
event E1 = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
121-
Q1, []() {});
122-
event E2 = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
123-
Q2, []() {});
120+
event E1 =
121+
single_task_wrapper<TestKernel>(ShortcutSubmitFunction, Q1, []() {});
122+
event E2 =
123+
single_task_wrapper<TestKernel>(ShortcutSubmitFunction, Q2, []() {});
124124
ExpectedEvent = detail::getSyclObjImpl(E2)->getHandle();
125125
Q1.ext_oneapi_submit_barrier({E1, E2});
126126
EXPECT_TRUE(BarrierCalled);
@@ -150,9 +150,9 @@ TEST_P(SchedulerTest, TwoInOrderQueuesOnSameContext) {
150150
property::queue::in_order()};
151151

152152
event EvFirst = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
153-
InOrderQueueFirst, []() {});
154-
std::ignore = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
155-
InOrderQueueSecond, EvFirst, []() {});
153+
InOrderQueueFirst, []() {});
154+
std::ignore = single_task_wrapper<TestKernel>(
155+
ShortcutSubmitFunction, InOrderQueueSecond, EvFirst, []() {});
156156

157157
InOrderQueueFirst.wait();
158158
InOrderQueueSecond.wait();
@@ -175,9 +175,9 @@ TEST_P(SchedulerTest, InOrderQueueNoSchedulerPath) {
175175
queue InOrderQueue{Ctx, default_selector_v, property::queue::in_order()};
176176

177177
event EvFirst = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
178-
InOrderQueue, []() {});
178+
InOrderQueue, []() {});
179179
std::ignore = single_task_wrapper<TestKernel>(ShortcutSubmitFunction,
180-
InOrderQueue, EvFirst, []() {});
180+
InOrderQueue, EvFirst, []() {});
181181

182182
InOrderQueue.wait();
183183

@@ -190,4 +190,5 @@ TEST_P(SchedulerTest, InOrderQueueNoSchedulerPath) {
190190

191191
} // anonymous namespace
192192

193-
INSTANTIATE_TEST_SUITE_P(SchedulerTestInstance, SchedulerTest, testing::Values(true, false));
193+
INSTANTIATE_TEST_SUITE_P(SchedulerTestInstance, SchedulerTest,
194+
testing::Values(true, false));

0 commit comments

Comments
 (0)