Skip to content

Commit 6f18156

Browse files
authored
[SYCL][NFC] Use move on queue parameters (#16326)
This addresses Coverity issues. Signed-off-by: Michael Aziz <[email protected]>
1 parent 046c807 commit 6f18156

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

sycl/source/detail/kernel_impl.hpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,8 @@ inline typename syclex::info::kernel_queue_specific::max_num_work_groups::
355355
syclex::info::kernel_queue_specific::max_num_work_groups>(
356356
queue Queue, const range<1> &WorkGroupSize,
357357
size_t DynamicLocalMemorySize) const {
358-
return queryMaxNumWorkGroups(Queue, WorkGroupSize, DynamicLocalMemorySize);
358+
return queryMaxNumWorkGroups(std::move(Queue), WorkGroupSize,
359+
DynamicLocalMemorySize);
359360
}
360361

361362
template <>
@@ -365,7 +366,8 @@ inline typename syclex::info::kernel_queue_specific::max_num_work_groups::
365366
syclex::info::kernel_queue_specific::max_num_work_groups>(
366367
queue Queue, const range<2> &WorkGroupSize,
367368
size_t DynamicLocalMemorySize) const {
368-
return queryMaxNumWorkGroups(Queue, WorkGroupSize, DynamicLocalMemorySize);
369+
return queryMaxNumWorkGroups(std::move(Queue), WorkGroupSize,
370+
DynamicLocalMemorySize);
369371
}
370372

371373
template <>
@@ -375,7 +377,8 @@ inline typename syclex::info::kernel_queue_specific::max_num_work_groups::
375377
syclex::info::kernel_queue_specific::max_num_work_groups>(
376378
queue Queue, const range<3> &WorkGroupSize,
377379
size_t DynamicLocalMemorySize) const {
378-
return queryMaxNumWorkGroups(Queue, WorkGroupSize, DynamicLocalMemorySize);
380+
return queryMaxNumWorkGroups(std::move(Queue), WorkGroupSize,
381+
DynamicLocalMemorySize);
379382
}
380383

381384
} // namespace detail

sycl/source/kernel.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,30 +108,30 @@ kernel::get_info<info::kernel_device_specific::max_sub_group_size>(
108108
template <typename Param>
109109
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
110110
kernel::ext_oneapi_get_info(queue Queue) const {
111-
return impl->ext_oneapi_get_info<Param>(Queue);
111+
return impl->ext_oneapi_get_info<Param>(std::move(Queue));
112112
}
113113

114114
template <typename Param>
115115
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
116116
kernel::ext_oneapi_get_info(queue Queue, const range<1> &WorkGroupSize,
117117
size_t DynamicLocalMemorySize) const {
118-
return impl->ext_oneapi_get_info<Param>(Queue, WorkGroupSize,
118+
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WorkGroupSize,
119119
DynamicLocalMemorySize);
120120
}
121121

122122
template <typename Param>
123123
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
124124
kernel::ext_oneapi_get_info(queue Queue, const range<2> &WorkGroupSize,
125125
size_t DynamicLocalMemorySize) const {
126-
return impl->ext_oneapi_get_info<Param>(Queue, WorkGroupSize,
126+
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WorkGroupSize,
127127
DynamicLocalMemorySize);
128128
}
129129

130130
template <typename Param>
131131
typename detail::is_kernel_queue_specific_info_desc<Param>::return_type
132132
kernel::ext_oneapi_get_info(queue Queue, const range<3> &WorkGroupSize,
133133
size_t DynamicLocalMemorySize) const {
134-
return impl->ext_oneapi_get_info<Param>(Queue, WorkGroupSize,
134+
return impl->ext_oneapi_get_info<Param>(std::move(Queue), WorkGroupSize,
135135
DynamicLocalMemorySize);
136136
}
137137

@@ -185,7 +185,7 @@ __SYCL_EXPORT typename ext::oneapi::experimental::info::kernel_queue_specific::
185185
size_t DynamicLocalMemorySize) const {
186186
return ext_oneapi_get_info<ext::oneapi::experimental::info::
187187
kernel_queue_specific::max_num_work_groups>(
188-
Queue, WorkGroupSize, DynamicLocalMemorySize);
188+
std::move(Queue), WorkGroupSize, DynamicLocalMemorySize);
189189
}
190190
template <>
191191
__SYCL2020_DEPRECATED(
@@ -201,7 +201,7 @@ __SYCL_EXPORT typename ext::oneapi::experimental::info::kernel_queue_specific::
201201
const sycl::range<3> WorkGroupSize{MaxWorkGroupSize, 1, 1};
202202
return ext_oneapi_get_info<ext::oneapi::experimental::info::
203203
kernel_queue_specific::max_num_work_groups>(
204-
Queue, WorkGroupSize,
204+
std::move(Queue), WorkGroupSize,
205205
/* DynamicLocalMemorySize */ 0);
206206
}
207207
#endif

0 commit comments

Comments
 (0)