Skip to content

Commit 7123b46

Browse files
committed
Apply remaining comments
1 parent f5418d7 commit 7123b46

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

sycl/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ set(SYCL_EXT_ONEAPI_BACKEND_HIP ${LLVM_HAS_AMDGPU_TARGET})
189189

190190
# Configure SYCL version macro
191191
set(SYCL_ROOT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
192-
set(sycl_src_dir ${CMAKE_CURRENT_SOURCE_DIR}/source)
192+
set(sycl_src_dir ${SYCL_ROOT_SOURCE_DIR}/source)
193193
include(SYCLVersionFromVCS)
194194
configure_file("source/feature_test.hpp.in" "${SYCL_INCLUDE_BUILD_DIR}/sycl/feature_test.hpp")
195195

@@ -216,7 +216,7 @@ install(FILES
216216
include(AddBoostMp11Headers)
217217
include(FetchBoostUnorderedHeaders)
218218

219-
set(sycl_inc_dir ${CMAKE_CURRENT_SOURCE_DIR}/include)
219+
set(sycl_inc_dir ${SYCL_ROOT_SOURCE_DIR}/include)
220220
# This is workaround to detect changes (add or modify) in subtree which
221221
# are not detected by copy_directory command.
222222
# TODO: detect and process remove header/directory case

sycl/test/warnings/sycl-compiler-version-cl.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,4 @@
77

88
// CHECK: '__SYCL_COMPILER_VERSION': name was marked as #pragma deprecated
99
#if __SYCL_COMPILER_VERSION >= 2024
10-
1110
#endif
12-
13-
int main() {}

sycl/test/warnings/sycl-compiler-version-clang.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,4 @@
44

55
// expected-warning@+1 {{__SYCL_COMPILER_VERSION is deprecated, use __LIBSYCL_TIMESTAMP instead}}
66
#if __SYCL_COMPILER_VERSION >= 2024
7-
87
#endif
9-
10-
int main() {}
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
// RUN: %clangxx -fsycl -fsycl-host-compiler=g++ %s -c %t.out | FileCheck %s
22
// XFAIL: *
3-
// XFAIL-TRACKER: TBD
3+
// It seems like gcc doesn't properly support _Pragma directive as its own
4+
// documentation says. Therefore, for gcc as host compiler we don't currently
5+
// emit a deprecation warning.
46
// REQUIRES: linux
57

68
#include <sycl/sycl.hpp>
79

810
// CHECK: __SYCL_COMPILER_VERSION is deprecated, use __LIBSYCL_TIMESTAMP instead
911
#if __SYCL_COMPILER_VERSION >= 2024
10-
1112
#endif
12-
13-
int main() {}

0 commit comments

Comments
 (0)