Addressed review comments.

Author: zahiraam

clang/include/clang/Driver/Options.td

@@ -1158,20 +1158,20 @@ defm cx_fortran_rules: BoolOptionWithoutMarshalling<"f", "cx-fortran-rules",
   "for complex arithmetic operations">>;
 
  defm offload_fp32_prec_div: BoolOption<"f", "offload-fp32-prec-div",
-  LangOpts<"OffloadFp32PrecDiv">, DefaultTrue,
-  PosFlag<SetTrue, [], [ClangOption, CC1Option], "fdiv operations in offload device "
-  "code are required to return correctly rounded results.">,
-  NegFlag<SetFalse, [], [ClangOption, CC1Option], "fdiv operations in offload device "
-  "code are not required to return correctly rounded results.">>,
-  Group<f_Group>;
+   LangOpts<"OffloadFp32PrecDiv">, DefaultTrue,
+   PosFlag<SetTrue, [], [ClangOption, CC1Option], "fdiv operations in offload device "
+   "code are required to return correctly rounded results.">,
+   NegFlag<SetFalse, [], [ClangOption, CC1Option], "fdiv operations in offload device "
+   "code are not required to return correctly rounded results.">>,
+   Group<f_Group>;
 
  defm offload_fp32_prec_sqrt: BoolOption<"f", "offload-fp32-prec-sqrt",
- LangOpts<"OffloadFp32PrecSqrt">, DefaultTrue,
-  PosFlag<SetTrue, [], [ClangOption, CC1Option], "sqrt operations in offload device "
-  "code are required to return correctly rounded results.">,
-  NegFlag<SetFalse, [], [ClangOption, CC1Option], "sqrt operations in offload device "
-  "code are not required to return correctly rounded results.">>,
-  Group<f_Group>;
+   LangOpts<"OffloadFp32PrecSqrt">, DefaultTrue,
+   PosFlag<SetTrue, [], [ClangOption, CC1Option], "sqrt operations in offload device "
+   "code are required to return correctly rounded results.">,
+   NegFlag<SetFalse, [], [ClangOption, CC1Option], "sqrt operations in offload device "
+   "code are not required to return correctly rounded results.">>,
+   Group<f_Group>;
 
 // OpenCL-only Options
 def cl_opt_disable : Flag<["-"], "cl-opt-disable">, Group<opencl_Group>,

clang/lib/Driver/ToolChains/Clang.cpp

@@ -3008,6 +3008,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D,
   std::string GccRangeComplexOption = "";
   bool NoOffloadFp32PrecDiv = false;
   bool NoOffloadFp32PrecSqrt = false;
+  bool IsDeviceOffloading = JA.isDeviceOffloading(Action::OFK_SYCL);
 
   // Lambda to set fast-math options. This is also used by -ffp-model=fast
   auto applyFastMath = [&]() {
@@ -3037,8 +3038,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D,
               : ComplexArithmeticStr(LangOptions::ComplexRangeKind::CX_Basic));
     Range = LangOptions::ComplexRangeKind::CX_Basic;
     SeenUnsafeMathModeOption = true;
-    if (JA.isDeviceOffloading(Action::OFK_SYCL) ||
-        JA.isDeviceOffloading(Action::OFK_OpenMP)) {
+    if (IsDeviceOffloading) {
       // when fp-model=fast is used the default precision for division and
       // sqrt is not precise.
       NoOffloadFp32PrecDiv = true;
@@ -3087,8 +3087,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D,
   };
 
   auto addSPIRVArgs = [&](StringRef SPIRVArg) {
-    if (JA.isDeviceOffloading(Action::OFK_SYCL) ||
-        JA.isDeviceOffloading(Action::OFK_OpenMP)) {
+    if (IsDeviceOffloading) {
       if (!FPAccuracy.empty())
         EmitAccuracyDiag(D, JA, FPAccuracy, SPIRVArg);
 
@@ -3621,8 +3620,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D,
     CmdArgs.push_back("-fno-cx-limited-range");
   if (Args.hasArg(options::OPT_fno_cx_fortran_rules))
     CmdArgs.push_back("-fno-cx-fortran-rules");
-  if (JA.isDeviceOffloading(Action::OFK_SYCL) ||
-      JA.isDeviceOffloading(Action::OFK_OpenMP)) {
+  if (IsDeviceOffloading) {
     if (NoOffloadFp32PrecDiv)
       CmdArgs.push_back("-fno-offload-fp32-prec-div");
     if (NoOffloadFp32PrecSqrt)