Skip to content

Commit 76cffd3

Browse files
[CI] Tweak wording for builds with passing tests and build errors (#171436)
"All tests passed" is too easily interpreted as every possible test was run and was fine. A lot of the time it means all the tests that didn't fail to build ran and were fine. Maybe the wording is still too subtle but at least it hints to the idea that the tests run might be fewer than if the build had no compilation errors.
1 parent c61a481 commit 76cffd3

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.ci/generate_test_report_lib.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def plural(num_tests):
267267
report.extend(
268268
[
269269
"",
270-
"All tests passed but another part of the build **failed**. "
270+
"All executed tests passed, but another part of the build **failed**. "
271271
"Information about the build failure could not be automatically "
272272
"obtained.",
273273
"",
@@ -278,7 +278,7 @@ def plural(num_tests):
278278
report.extend(
279279
[
280280
"",
281-
"All tests passed but another part of the build **failed**. Click on "
281+
"All executed tests passed, but another part of the build **failed**. Click on "
282282
"a failure below to see the details.",
283283
"",
284284
]

.ci/generate_test_report_lib_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def test_no_failures_build_failed(self):
343343
344344
* 1 test passed
345345
346-
All tests passed but another part of the build **failed**. Information about the build failure could not be automatically obtained.
346+
All executed tests passed, but another part of the build **failed**. Information about the build failure could not be automatically obtained.
347347
348348
Download the build's log file to see the details.
349349
@@ -390,7 +390,7 @@ def test_no_failures_build_failed_ninja_log(self):
390390
391391
* 1 test passed
392392
393-
All tests passed but another part of the build **failed**. Click on a failure below to see the details.
393+
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
394394
395395
<details>
396396
<summary>test/4.stamp</summary>
@@ -476,7 +476,7 @@ def test_no_failures_multiple_build_failed_ninja_log(self):
476476
477477
* 1 test passed
478478
479-
All tests passed but another part of the build **failed**. Click on a failure below to see the details.
479+
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
480480
481481
<details>
482482
<summary>touch test/2.stamp</summary>
@@ -978,7 +978,7 @@ def test_generate_report_end_to_end(self):
978978
979979
* 1 test passed
980980
981-
All tests passed but another part of the build **failed**. Click on a failure below to see the details.
981+
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.
982982
983983
<details>
984984
<summary>test/4.stamp</summary>

0 commit comments

Comments
 (0)