Skip to content

Commit 7974dbf

Browse files
committed
apply suggestion
1 parent 850ca83 commit 7974dbf

File tree

3 files changed

+22
-31
lines changed

3 files changed

+22
-31
lines changed

sycl/test-e2e/Basic/kernel_max_wg_size.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
// https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_intel_grf_size.asciidoc
66
// REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2
77
// UNSUPPORTED: cuda || hip
8-
// UNSUPPORTED-TRACKER: INTENDED - This extension is currently implemented in
9-
// DPC++ only for Intel GPU devices and only when using the Level Zero backend
10-
// or OpenCL backend.
8+
// UNSUPPORTED-INTENDED: This extension is currently implemented in DPC++ only
9+
// for Intel GPU devices and only when using the Level Zero backend or OpenCL
10+
// backend.
1111

1212
// clang-format off
1313
#include <sycl/detail/core.hpp>

sycl/test-e2e/README.md

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -353,29 +353,20 @@ Some tests may be considered unsupported, e.g.:
353353
* the test is flaky or hangs, so it can't be marked with `XFAIL`.
354354

355355
In these cases the test can be marked with `UNSUPPORTED`. This mark should be
356-
followed by `UNSUPPORTED-TRACKER`. There are two options:
357-
```
358-
UNSUPPORTED-TRACKER: INTENDED - <Free-text with reason why it's not intended to be supported on the given feature.>
359-
UNSUPPORTED-TRACKER: <github issue link / internal number>
360-
```
361-
362-
In the first case it should look like:
356+
followed by either `UNSUPPORTED-INTENDED` or `UNSUPPORTED-TRACKER` depending on
357+
whether the test is not intended to be run with some feature at all or it was
358+
temporarily disabled due to some issue.
363359
```
364360
// UNSUPPORTED: cuda, hip
365-
// UNSUPPORTED-TRACKER: INTENDED - only supported by backends with SPIR-V IR
361+
// UNSUPPORTED-INTENDED: only supported by backends with SPIR-V IR
366362
367-
// UNSUPPORTED: gpu
368-
// UNSUPPORTED-TRACKER: INTENDED - the feature works only on CPU & FPGA
369-
```
370-
371-
For the second case the tracker should be provided:
372-
```
373363
// Sporadically fails on DG2.
374364
// UNSUPPORTED: gpu-intel-dg2
375365
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/DDDDD
376366
// *OR*
377367
// UNSUPPORTED-TRACKER: PRJ-1234
378368
```
379369

380-
If you add `UNSUPPORTED` without `UNSUPPORTED-TRACKER` directive,
381-
`no-unsupported-without-tracker.cpp` test will fail, notifying you about that.
370+
If you add `UNSUPPORTED` without `UNSUPPORTED-TRACKER` or `UNSUPPORTED-INTENDED`
371+
directive, the `no-unsupported-without-tracker.cpp` test will fail, notifying
372+
you about that.

sycl/test/no-unsupported-without-tracker.cpp renamed to sycl/test/no-unsupported-without-info.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
1-
// This test is intended to ensure that we have no trackers marked as
2-
// UNSUPPORTED without a tracker information added to a test.
1+
// This test is intended to ensure that we have no tests marked as
2+
// UNSUPPORTED without an information added to a test.
33
// For more info see: sycl/test-e2e/README.md
44
//
55
// The format we check is:
66
// UNSUPPORTED: lit,features
7-
// UNSUPPORTED-TRACKER: [GitHub issue URL|Internal tracker ID|INTENDED - reason]
7+
// UNSUPPORTED-TRACKER: [GitHub issue URL|Internal tracker ID]
8+
// *OR*
9+
// UNSUPPORTED: lit,features
10+
// UNSUPPORTED-INTENDED: explanation why the test isn't intended to be run with this feature
811
//
912
// GitHub issue URL format:
1013
// https://github.com/owner/repo/issues/12345
1114
//
1215
// Internal tracker ID format:
1316
// PROJECT-123456
1417
//
15-
// Reason format:
16-
// Just a free form text
17-
//
1818
// REQUIRES: linux
1919
//
2020
// Explanation of the command:
2121
// - search for all "UNSUPPORTED" occurrences, display line with match and the next one
2222
// -I, --include to drop binary files and other unrelated files
2323
// - in the result, search for "UNSUPPORTED" again, but invert the result - this
2424
// allows us to get the line *after* UNSUPPORTED
25-
// - in those lines, check that UNSUPPORTED-TRACKER is present and correct. Once
26-
// again, invert the search to get all "bad" lines and save the test names in
27-
// the temp file
25+
// - in those lines, check that UNSUPPORTED-TRACKER or UNSUPPORTED-INTENDED is
26+
// present and correct. Once again, invert the search to get all "bad" lines
27+
// and save the test names in the temp file
2828
// - make a final count of how many ill-formatted directives there are and
2929
// verify that against the reference
3030
// - ...and check if the list of improperly UNSUPPORTED tests needs to be updated.
3131
//
3232
// RUN: grep -rI "UNSUPPORTED:" %S/../test-e2e \
3333
// RUN: -A 1 --include=*.c --include=*.cpp --no-group-separator | \
3434
// RUN: grep -v "UNSUPPORTED:" | \
35-
// RUN: grep -Pv "UNSUPPORTED-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)|(?:INTENDED\s*-\s*.+)" > %t | \
36-
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-UNSUPPORTED-WITHOUT-TRACKER
35+
// RUN: grep -Pv "UNSUPPORTED-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)|(?:UNSUPPORTED-INTENDED:\s*.+)" > %t | \
36+
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-UNSUPPORTED-WITHOUT-INFO
3737
// RUN: cat %t | sed 's/\.cpp.*/.cpp/' | sort | FileCheck %s
3838
//
3939
// The number below is a number of tests which are *improperly* UNSUPPORTED, i.e.
@@ -54,7 +54,7 @@
5454
// tests to match the required format and in that case you should just update
5555
// (i.e. reduce) the number and the list below.
5656
//
57-
// NUMBER-OF-UNSUPPORTED-WITHOUT-TRACKER: 484
57+
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 484
5858
//
5959
// List of improperly UNSUPPORTED tests.
6060
// Remove the CHECK once the test has been propely UNSUPPORTED.

0 commit comments

Comments
 (0)