Skip to content

Commit 7b2ac54

Browse files
authored
[Benchmarks] Split SubmitGraph grouping (#19652)
Make SubmitGraph benchmarks groupings more fine-grained. Refactor displayed names of these benchmarks to follow the convention of SubmitKernel benchmarks. Examples: <img width="700" height="117" alt="image" src="https://github.com/user-attachments/assets/096eec89-c6ee-49ea-8ac9-3f0a223d2dca" /> <img width="417" height="79" alt="image" src="https://github.com/user-attachments/assets/bc21fefe-092e-4875-a7fa-39d0dcdf9a05" />
1 parent 464871d commit 7b2ac54

File tree

1 file changed

+23
-3
lines changed

1 file changed

+23
-3
lines changed

devops/scripts/benchmarks/benches/compute.py

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def runtime_to_tag_name(runtime: RUNTIMES) -> str:
4242
class ComputeBench(Suite):
4343
def __init__(self, directory):
4444
self.directory = directory
45+
self.submit_graph_num_kernels = [4, 10, 32]
4546

4647
def name(self) -> str:
4748
return "Compute Benchmarks"
@@ -143,6 +144,19 @@ def additional_metadata(self) -> dict[str, BenchmarkMetadata]:
143144
range_min=base_metadata.range_min,
144145
)
145146

147+
# Add metadata for all SubmitGraph group variants
148+
base_metadata = metadata["SubmitGraph"]
149+
for order in ["in order", "out of order"]:
150+
for completion in ["", " with completion"]:
151+
for num_kernels in self.submit_graph_num_kernels:
152+
group_name = (
153+
f"SubmitGraph {order}{completion}, {num_kernels} kernels"
154+
)
155+
metadata[group_name] = BenchmarkMetadata(
156+
type="group",
157+
tags=base_metadata.tags,
158+
)
159+
146160
return metadata
147161

148162
def benchmarks(self) -> list[Benchmark]:
@@ -191,7 +205,7 @@ def benchmarks(self) -> list[Benchmark]:
191205

192206
# Add GraphApiSubmitGraph benchmarks
193207
for in_order_queue in [0, 1]:
194-
for num_kernels in [4, 10, 32]:
208+
for num_kernels in self.submit_graph_num_kernels:
195209
for measure_completion_time in [0, 1]:
196210
benches.append(
197211
GraphApiSubmitGraph(
@@ -818,12 +832,18 @@ def __init__(
818832
self.inOrderQueue = inOrderQueue
819833
self.numKernels = numKernels
820834
self.measureCompletionTime = measureCompletionTime
835+
self.ioq_str = "in order" if self.inOrderQueue else "out of order"
836+
self.measure_str = (
837+
" with measure completion" if self.measureCompletionTime else ""
838+
)
821839
super().__init__(
822840
bench, f"graph_api_benchmark_{runtime.value}", "SubmitGraph", runtime
823841
)
824842

825843
def explicit_group(self):
826-
return f"SubmitGraph, numKernels: {self.numKernels}"
844+
return (
845+
f"SubmitGraph {self.ioq_str}{self.measure_str}, {self.numKernels} kernels"
846+
)
827847

828848
def description(self) -> str:
829849
return (
@@ -835,7 +855,7 @@ def name(self):
835855
return f"graph_api_benchmark_{self.runtime.value} SubmitGraph numKernels:{self.numKernels} ioq {self.inOrderQueue} measureCompletion {self.measureCompletionTime}"
836856

837857
def display_name(self) -> str:
838-
return f"{self.runtime.value.upper()} SubmitGraph, numKernels {self.numKernels}, ioq {self.inOrderQueue}, measureCompletion {self.measureCompletionTime}"
858+
return f"{self.runtime.value.upper()} SubmitGraph {self.ioq_str}{self.measure_str}, {self.numKernels} kernels"
839859

840860
def get_tags(self):
841861
return [

0 commit comments

Comments
 (0)