Revert "[fir] Add Character helper"

This reverts commit e4ce922.

Buildbots not happy with the tests.

Author: clementval

flang/include/flang/Optimizer/Builder/Character.h

@@ -47,22 +47,9 @@ class FirOpBuilder : public mlir::OpBuilder {
     return getRegion().getParentOfType<mlir::ModuleOp>();
   }
 
-  /// Get the current Function
-  mlir::FuncOp getFunction() {
-    return getRegion().getParentOfType<mlir::FuncOp>();
-  }
-
   /// Get a reference to the kind map.
   const fir::KindMapping &getKindMap() { return kindMap; }
 
-  /// Get the entry block of the current Function
-  mlir::Block *getEntryBlock() { return &getFunction().front(); }
-
-  /// Get the block for adding Allocas. If OpenMP is enabled then get the
-  /// the alloca block from an Operation which can be Outlined. Otherwise
-  /// use the entry block of the current Function
-  mlir::Block *getAllocaBlock();
-
   /// Safely create a reference type to the type `eleTy`.
   mlir::Type getRefType(mlir::Type eleTy);
 
@@ -104,45 +91,6 @@ class FirOpBuilder : public mlir::OpBuilder {
     return createRealConstant(loc, realType, 0u);
   }
 
-  /// Create a slot for a local on the stack. Besides the variable's type and
-  /// shape, it may be given name, pinned, or target attributes.
-  mlir::Value allocateLocal(mlir::Location loc, mlir::Type ty,
-                            llvm::StringRef uniqName, llvm::StringRef name,
-                            bool pinned, llvm::ArrayRef<mlir::Value> shape,
-                            llvm::ArrayRef<mlir::Value> lenParams,
-                            bool asTarget = false);
-  mlir::Value allocateLocal(mlir::Location loc, mlir::Type ty,
-                            llvm::StringRef uniqName, llvm::StringRef name,
-                            llvm::ArrayRef<mlir::Value> shape,
-                            llvm::ArrayRef<mlir::Value> lenParams,
-                            bool asTarget = false);
-
-  /// Create a temporary. A temp is allocated using `fir.alloca` and can be read
-  /// and written using `fir.load` and `fir.store`, resp.  The temporary can be
-  /// given a name via a front-end `Symbol` or a `StringRef`.
-  mlir::Value createTemporary(mlir::Location loc, mlir::Type type,
-                              llvm::StringRef name = {},
-                              mlir::ValueRange shape = {},
-                              mlir::ValueRange lenParams = {},
-                              llvm::ArrayRef<mlir::NamedAttribute> attrs = {});
-
-  /// Create an unnamed and untracked temporary on the stack.
-  mlir::Value createTemporary(mlir::Location loc, mlir::Type type,
-                              mlir::ValueRange shape) {
-    return createTemporary(loc, type, llvm::StringRef{}, shape);
-  }
-
-  mlir::Value createTemporary(mlir::Location loc, mlir::Type type,
-                              llvm::ArrayRef<mlir::NamedAttribute> attrs) {
-    return createTemporary(loc, type, llvm::StringRef{}, {}, {}, attrs);
-  }
-
-  mlir::Value createTemporary(mlir::Location loc, mlir::Type type,
-                              llvm::StringRef name,
-                              llvm::ArrayRef<mlir::NamedAttribute> attrs) {
-    return createTemporary(loc, type, name, {}, {}, attrs);
-  }
-
   /// Create a global value.
   fir::GlobalOp createGlobal(mlir::Location loc, mlir::Type type,
                              llvm::StringRef name,

flang/include/flang/Optimizer/Builder/FIRBuilder.h

@@ -64,9 +64,6 @@ constexpr llvm::StringRef getContiguousAttrName() { return "fir.contiguous"; }
 /// Attribute to mark Fortran entities with the OPTIONAL attribute.
 constexpr llvm::StringRef getOptionalAttrName() { return "fir.optional"; }
 
-/// Attribute to mark Fortran entities with the TARGET attribute.
-static constexpr llvm::StringRef getTargetAttrName() { return "fir.target"; }
-
 /// Tell if \p value is:
 ///   - a function argument that has attribute \p attributeName
 ///   - or, the result of fir.alloca/fir.allocamem op that has attribute \p

flang/include/flang/Optimizer/Dialect/FIROpsSupport.h

@@ -161,12 +161,6 @@ inline mlir::Type unwrapSequenceType(mlir::Type t) {
   return t;
 }
 
-inline mlir::Type unwrapRefType(mlir::Type t) {
-  if (auto eleTy = dyn_cast_ptrEleTy(t))
-    return eleTy;
-  return t;
-}
-
 #ifndef NDEBUG
 // !fir.ptr<X> and !fir.heap<X> where X is !fir.ptr, !fir.heap, or !fir.ref
 // is undefined and disallowed.

flang/include/flang/Optimizer/Dialect/FIRType.h

@@ -1,8 +1,6 @@
 get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
-
 add_flang_library(FIRBuilder
   BoxValue.cpp
-  Character.cpp
   DoLoopHelper.cpp
   FIRBuilder.cpp