Skip to content

Commit 7c609b6

Browse files
Victor Lomullermaarquitos14
andauthored
Apply suggestions from code review
Co-authored-by: Marcos Maronas <[email protected]>
1 parent 566bebd commit 7c609b6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

llvm/lib/SYCLLowerIR/LowerWGLocalMemory.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ sycl::getKernelNamesUsingImplicitLocalMem(const Module &M) {
6060
if (F.getAttributes().hasParamAttr(Arg.getArgNo(),
6161
WORK_GROUP_STATIC_ARG_ATTR))
6262
return Arg.getArgNo();
63-
// Not lowered to an implicit arg or DAE
63+
// Not lowered to an implicit arg or DAE.
6464
return -1;
6565
};
6666
llvm::for_each(M.functions(), [&](const Function &F) {
@@ -171,9 +171,9 @@ static bool allocaWGLocalMemory(Module &M) {
171171
}
172172

173173
// For dynamic memory we have 2 case:
174-
// - Direct for CUDA/HIP: we create a placeholder and set the memory on launch
174+
// - Direct for CUDA/HIP: we create a placeholder and set the memory on launch.
175175
// - Indirect for OpenCL/Level0: we create a shared value holding the pointer
176-
// to the buffer passed as argument
176+
// to the buffer passed as argument.
177177
static bool dynamicWGLocalMemory(Module &M) {
178178
Function *DLMFunc = M.getFunction(SYCL_DYNAMIC_LOCALMEM_CALL);
179179
if (!DLMFunc)
@@ -272,7 +272,7 @@ static bool dynamicWGLocalMemory(Module &M) {
272272
OldKernel->getAllMetadata(MDs);
273273
for (const auto &MD : MDs)
274274
NewFunc->addMetadata(MD.first, *MD.second);
275-
// Store the pointer to the implict local memory into the global
275+
// Store the pointer to the implicit local memory into the global
276276
// handler.
277277
IRBuilder<> Builder(&NewFunc->getEntryBlock(),
278278
NewFunc->getEntryBlock().getFirstNonPHIIt());

0 commit comments

Comments
 (0)