Address feedback

Signed-off-by: Julian Oppermann <[email protected]>

Author: jopperm

sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp

@@ -451,7 +451,9 @@ llvm::Expected<PostLinkResult> jit_compiler::performPostLink(
   MDesc = std::move(ESIMDSplits.front());
 
   if (MDesc.isESIMD()) {
-    // TODO: We're assuming ESIMD lowering is not deactivated (why would it?).
+    // `sycl-post-link` has a `-lower-esimd` option, but there's no clang driver
+    // option to influence it. Rather, the driver sets it unconditionally in the
+    // multi-file output mode, which we are mimicking here.
     lowerEsimdConstructs(MDesc, PerformOpts);
   }
 

sycl-jit/jit-compiler/lib/rtc/ESIMD.cpp

@@ -52,7 +52,7 @@ void jit_compiler::lowerEsimdConstructs(module_split::ModuleDesc &MD,
   FunctionPassManager MainFPM;
   MainFPM.addPass(ESIMDLowerLoadStorePass{});
 
-  if (!PerformOpts) {
+  if (PerformOpts) {
     MainFPM.addPass(SROAPass(SROAOptions::ModifyCFG));
     MainFPM.addPass(EarlyCSEPass(true));
     MainFPM.addPass(InstCombinePass{});

sycl-jit/jit-compiler/lib/rtc/ESIMD.h

@@ -14,7 +14,7 @@
 namespace jit_compiler {
 
 // Runs a pass pipeline to lower ESIMD constructs on the given split model,
-// which may only contain ESIMD entrypoints. This is a copy of the similar
+// which must only contain ESIMD entrypoints. This is a copy of the similar
 // function in `sycl-post-link`.
 void lowerEsimdConstructs(llvm::module_split::ModuleDesc &MD, bool PerformOpts);