Skip to content

Commit 82a4c40

Browse files
Update a comment on trivial vs trivially_copyable issue
1 parent 506df5f commit 82a4c40

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

sycl/include/sycl/ext/oneapi/experimental/user_defined_reductions.hpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ T reduce_over_group_impl(GroupHelper group_helper, T x, size_t num_elements,
2828
// g.get_local_linear_id()!
2929

3030
// It seems shift_group_left is overly restrictive and requires trivial types
31-
// instead of trivially copyable.
31+
// instead of trivially copyable. Existing
32+
// `test-e2e/UserDefinedReductions/user_defined_reductions.cpp` can be used to
33+
// see the issue.
3234
if constexpr (sycl::detail::is_sub_group<decltype(g)>::value &&
3335
std::is_trivial_v<T>) {
3436
// sycl::ext::oneapi::sub_group isn't sycl::sub_group, and shift_group_left

0 commit comments

Comments
 (0)