Skip to content

Commit 83ffd0a

Browse files
author
Colin Davidson
committed
Update after review comments
1 parent a86340c commit 83ffd0a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+238
-137
lines changed

sycl/test-e2e/Adapters/enqueue-arg-order-image.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// REQUIRES: aspect-ext_intel_legacy_image
2-
// UNSUPPORTED: target-amd || target-native_cpu
2+
// UNSUPPORTED: target-amd
33
// UNSUPPORTED-INTENDED: Legacy images aren't supported on AMD, but also fail
44
// to compile. Bindless images should be used instead.
55

@@ -20,6 +20,9 @@
2020
// resolved and 2 is merged we will re-enable Image support.
2121
// UNSUPPORTED: spirv-backend && arch-intel_gpu_bmg_g21
2222
// UNSUPPORTED-TRACKER: https://github.com/KhronosGroup/SPIRV-Headers/issues/487
23+
// UNSUPPORTED: target-native_cpu
24+
// UNSUPPORTED-INTENDED: Legacy images aren't supported on Native CPU but also fail
25+
// to compile. Bindless images should be used when that is working.
2326

2427
#include <iostream>
2528

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1-
# Currently mark Native CPU as unsupported, does not compile and should be investigated and tracked post team transfer
1+
# Currently mark Native CPU as unsupported, does not compile and should be
2+
# investigated and tracked post team transfer
23
config.unsupported_features += ['target-native_cpu']

sycl/test-e2e/Adapters/queue_submit_mode.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
// REQUIRES: gpu, level_zero
22
// UNSUPPORTED: level_zero_v2_adapter
33
// UNSUPPORTED-INTENDED: v2 adapter does support regular cmd lists
4-
// UNSUPPORTED: target-native_cpu
5-
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, should be
6-
// investigated and tracked post team transfer
74
// RUN: %{build} %level_zero_options -o %t.out
85
// RUN: env %{l0_leak_check} SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{run} %t.out 0 2>&1 | FileCheck %s --check-prefixes=CHECK-STD
96
// RUN: env %{l0_leak_check} SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{run} %t.out 1 2>&1 | FileCheck %s --check-prefixes=CHECK-IMM
107
//
8+
// UNSUPPORTED: target-native_cpu
9+
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, it should be
10+
// investigated and tracked post team transfer.
11+
//
1112
// Check that queue submission mode is honored when creating queue.
1213
//
1314
#include <iostream>

sycl/test-e2e/AddressSanitizer/lit.local.cfg

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ config.unsupported_features += ['spirv-backend']
2121
# https://github.com/intel/llvm/issues/16920
2222
config.unsupported_features += ['arch-intel_gpu_bmg_g21']
2323

24-
# AddressSanitizer currently not supported for Native CPU
24+
# AddressSanitizer currently not supported for Native CPU, it should be
25+
# investigated and tracked post team transfer.
2526
config.unsupported_features += ['target-native_cpu']
2627
unsupported_san_flags = [
2728
# "-fsanitize=address",

sycl/test-e2e/Assert/check_resource_leak.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
// RUN: %{build} -Wno-error=#warnings -o %t.out
22
// RUN: %{run} %t.out
33

4-
// Device globals aren't supported on opencl:gpu or Native CPU yet.
5-
// UNSUPPORTED: (opencl && gpu) || target-native_cpu
4+
// Device globals aren't supported on opencl:gpu yet.
5+
// UNSUPPORTED: opencl && gpu
6+
// UNSUPPORTED: target-native_cpu
7+
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, it should be
8+
// investigated and tracked post team transfer.
69

710
// TODO: Fails at JIT compilation for some reason.
811
// UNSUPPORTED: hip
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1-
# BFloat16 is not supported on Native CPU
1+
# BFloat16 not yet supported. It should be investigated and tracked post team
2+
# transfer.
23
config.unsupported_features += ['target-native_cpu']

sycl/test-e2e/Basic/built-ins/marray_math.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
// UNSUPPORTED: target-native_cpu
2-
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, should be
3-
// investigated and tracked post team transfer
4-
51
// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}
62

73
// RUN: %{build} %{mathflags} -o %t.out
84
// RUN: %{run} %t.out
5+
//
6+
// UNSUPPORTED: target-native_cpu
7+
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, it should be
8+
// investigated and tracked post team transfer
99

1010
#include <cmath>
1111
#include <sycl/detail/core.hpp>

sycl/test-e2e/Basic/image/lit.local.cfg

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
# https://github.com/KhronosGroup/SPIRV-Headers/issues/487
44
# After the issue is resolved we will re-enable Image support.
55
#
6-
# Legacy images aren't supported on AMD and Native CPU and also don't compile, so mark them
6+
# Legacy images aren't supported on AMD and also don't compile, so mark them
77
# unsupported here. Bindless images should be used instead.
8-
config.unsupported_features += ['spirv-backend', 'target-amd', 'target-native_cpu']
8+
config.unsupported_features += ['spirv-backend', 'target-amd']
9+
10+
# Legacy images aren't supported on Native CPU and also don't compile, so mark
11+
# them unsupported here. Bindless images should be used instead when they are
12+
# working. This should be investigated and tracked post team transfer.
13+
config.unsupported_features += ['target-native_cpu']

sycl/test-e2e/Basic/vector/load_store.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
// UNSUPPORTED: target-native_cpu
2-
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, should be
3-
// investigated and tracked post team transfer
4-
51
// RUN: %{build} -o %t.out
62
// RUN: %{run} %t.out
73

84
// RUN: %if preview-breaking-changes-supported %{ %{build} -fpreview-breaking-changes -o %t2.out %}
95
// RUN: %if preview-breaking-changes-supported %{ %{run} %t2.out %}
106

7+
// UNSUPPORTED: target-native_cpu
8+
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, it should be
9+
// investigated and tracked post team transfer
10+
1111
// Tests load and store on sycl::vec.
1212

1313
#include <sycl/detail/core.hpp>

sycl/test-e2e/Complex/sycl_complex_math_test.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
// UNSUPPORTED: target-native_cpu
2-
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, should be
3-
// investigated and tracked post team transfer.
4-
51
// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}
62

73
// RUN: %{build} -Wno-error=deprecated-declarations -fsycl-device-code-split=per_kernel %{mathflags} -o %t.out
84
// RUN: %{run} %t.out
5+
// UNSUPPORTED: target-native_cpu
6+
// UNSUPPORTED-INTENDED: Currently mark Native CPU as unsupported, it should be
7+
// investigated and tracked post team transfer.
98

109
#include "sycl_complex_helper.hpp"
1110
#include "sycl_complex_math_test_cases.hpp"

0 commit comments

Comments
 (0)