WIP

Author: AlexeySachkov

sycl/source/handler.cpp

@@ -262,18 +262,27 @@ fill_copy_args(detail::handler_impl *impl,
   auto ZCopyExtentComponent = detail::fill_image_type(SrcImgDesc, UrSrcDesc);
   detail::fill_image_type(DestImgDesc, UrDestDesc);
 
-  impl->MSrcOffset = {SrcOffset[0], SrcOffset[1], SrcOffset[2]};
-  impl->MDestOffset = {DestOffset[0], DestOffset[1], DestOffset[2]};
+  // Copy args computed here are directly passed to UR. Various offsets and
+  // extents end up passed as ur_rect_offset_t and ur_rect_region_t. Both those
+  // structs expect theirfirst component to be in bytes, not in pixels
+  size_t SrcPixelSize = SrcImgDesc.num_channels * get_channel_size(SrcImgDesc);
+  size_t DestPixelSize =
+      DestImgDesc.num_channels * get_channel_size(DestImgDesc);
+
+  impl->MSrcOffset = {SrcOffset[0] * SrcPixelSize, SrcOffset[1], SrcOffset[2]};
+  impl->MDestOffset = {DestOffset[0] * DestPixelSize, DestOffset[1],
+                       DestOffset[2]};
   impl->MSrcImageDesc = UrSrcDesc;
   impl->MDstImageDesc = UrDestDesc;
   impl->MSrcImageFormat = UrSrcFormat;
   impl->MDstImageFormat = UrDestFormat;
   impl->MImageCopyFlags = ImageCopyFlags;
 
   if (CopyExtent.size() != 0) {
-    impl->MCopyExtent = {CopyExtent[0], CopyExtent[1], CopyExtent[2]};
+    impl->MCopyExtent = {CopyExtent[0] * SrcPixelSize, CopyExtent[1],
+                         CopyExtent[2]};
   } else {
-    impl->MCopyExtent = {SrcImgDesc.width, SrcImgDesc.height,
+    impl->MCopyExtent = {SrcImgDesc.width * SrcPixelSize, SrcImgDesc.height,
                          ZCopyExtentComponent};
   }
 

unified-runtime/source/adapters/level_zero/image_common.cpp

@@ -747,11 +747,20 @@ ur_result_t getImageRegionHelper(ze_image_desc_t ZeImageDesc,
       UR_RESULT_ERROR_INVALID_VALUE);
 #endif // !NDEBUG
 
-  uint32_t OriginX = ur_cast<uint32_t>(Origin->x);
+  // ur_rect_offset_t and ur_rect_region_t describe first component using bytes
+  // ze_image_region_t however uses pixels for it
+
+  // TODO: this is less efficient than a direct calculation of a pixel size
+  // using ze_image_format_t
+  ur_image_format_t UrImageFormat;
+  UR_CALL(ze2urImageFormat(ZeImageDesc.format, &UrImageFormat));
+  uint32_t PixelSizeBytes = getPixelSizeBytes(&UrImageFormat);
+
+  uint32_t OriginX = ur_cast<uint32_t>(Origin->x) / PixelSizeBytes;
   uint32_t OriginY = ur_cast<uint32_t>(Origin->y);
   uint32_t OriginZ = ur_cast<uint32_t>(Origin->z);
 
-  uint32_t Width = ur_cast<uint32_t>(Region->width);
+  uint32_t Width = ur_cast<uint32_t>(Region->width) / PixelSizeBytes;
   uint32_t Height = (ZeImageDesc.type == ZE_IMAGE_TYPE_1DARRAY)
                         ? ZeImageDesc.arraylevels
                         : ur_cast<uint32_t>(Region->height);