Skip to content

Commit 8964513

Browse files
Revert "[SYCL] Fix ABI break after "Refactor HandlerAccess::postProcess" (#19502)"
This reverts commit 20b247c.
1 parent 821810c commit 8964513

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

sycl/source/handler.cpp

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -458,28 +458,6 @@ detail::EventImplPtr handler::finalize() {
458458
#else
459459
event handler::finalize() {
460460
#endif
461-
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
462-
// Old reduction implementation, prior to
463-
// https://github.com/intel/llvm/pull/18794
464-
// https://github.com/intel/llvm/pull/18898
465-
// https://github.com/intel/llvm/pull/19203
466-
// relied on explicit calls to handler::finalize and those calls were inlined
467-
// into the user applications. As such, we have to preserve the following
468-
// behavior for ABI-compatibility purposes:
469-
if (MIsFinalizedDoNotUse)
470-
return MLastEventDoNotUse;
471-
472-
MIsFinalizedDoNotUse = true;
473-
// Use macros to trick clang-format:
474-
#define WRAP_BODY_BEGIN MLastEventDoNotUse = [this]() {
475-
#define WRAP_BODY_END \
476-
} \
477-
(); \
478-
return MLastEventDoNotUse;
479-
480-
WRAP_BODY_BEGIN
481-
#endif
482-
483461
const auto &type = getType();
484462
detail::queue_impl *Queue = impl->get_queue_or_null();
485463
ext::oneapi::experimental::detail::graph_impl *Graph =
@@ -982,13 +960,6 @@ event handler::finalize() {
982960
#else
983961
return detail::createSyclObjFromImpl<event>(Event);
984962
#endif
985-
986-
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
987-
WRAP_BODY_END
988-
989-
#undef WRAP_BODY_BEGIN
990-
#undef WRAP_BODY_END
991-
#endif
992963
}
993964

994965
void handler::addReduction(const std::shared_ptr<const void> &ReduObj) {

0 commit comments

Comments
 (0)