Skip to content

Commit 92a5652

Browse files
[CI] Backward-compatibility testing against sycl-rel-6_3 (#19761)
Looks like we have three runners with `pvc` label and only one of them has `build` on it too (and we have three more non-`pvc` `build` runners), so I wouldn't expect `pvc` tasks to be a bottleneck.
1 parent e8c8555 commit 92a5652

File tree

3 files changed

+36
-3
lines changed

3 files changed

+36
-3
lines changed

.github/workflows/sycl-linux-precommit.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ jobs:
8383
name: Read compatibility testing exclude list
8484
runs-on: [Linux, build]
8585
outputs:
86-
FILTER: ${{ steps.result.outputs.FILTER }}
86+
FILTER_6_2: ${{ steps.result.outputs.FILTER_6_2 }}
87+
FILTER_6_3: ${{ steps.result.outputs.FILTER_6_3 }}
8788
steps:
8889
- uses: actions/checkout@v4
8990
with:
@@ -96,7 +97,8 @@ jobs:
9697
run: |
9798
# Transform to format expected by `llvm-lit --filter-out "pattern1|pattern2|..."`.
9899
# First, remove comments/empty lines, then join lines with "|" as separator.
99-
echo FILTER="$(grep -v '^#\|^\W*$' devops/compat_ci_exclude.sycl-rel-6_2 | paste -sd '|')" >> $GITHUB_OUTPUT
100+
echo FILTER_6_2="$(grep -v '^#\|^\W*$' devops/compat_ci_exclude.sycl-rel-6_2 | paste -sd '|')" >> $GITHUB_OUTPUT
101+
echo FILTER_6_3="$(grep -v '^#\|^\W*$' devops/compat_ci_exclude.sycl-rel-6_3 | paste -sd '|')" >> $GITHUB_OUTPUT
100102
101103
run_prebuilt_e2e_tests:
102104
needs: [build, detect_changes, compat_read_exclude]
@@ -147,7 +149,13 @@ jobs:
147149
runner: '["Linux", "pvc"]'
148150
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2
149151
target_devices: level_zero:gpu
150-
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER }}"'
152+
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_2 }}"'
153+
e2e_binaries_artifact: 'in-container'
154+
- name: ABI compatibility against sycl-rel-6_3
155+
runner: '["Linux", "pvc"]'
156+
image: ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_3
157+
target_devices: level_zero:gpu
158+
extra_lit_opts: '--param test-preview-mode=False --filter-out "${{ needs.compat_read_exclude.outputs.FILTER_6_3 }}"'
151159
e2e_binaries_artifact: 'in-container'
152160

153161
uses: ./.github/workflows/sycl-linux-run-tests.yml

.github/workflows/sycl-linux-run-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ on:
159159
options:
160160
- 'ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest'
161161
- 'ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2'
162+
- 'ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_3'
162163
- 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'
163164
image_options:
164165
description: |

devops/compat_ci_exclude.sycl-rel-6_3

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Failed against sycl-rel-6_3 toolchain when creating the container:
2+
Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp
3+
Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp
4+
5+
# Likely OK, but need author to provide justification, get approval/confirmation
6+
# from someone:
7+
8+
# https://github.com/intel/llvm/pull/18565
9+
# This one should have probably be done in multiple PRs, first improving the
10+
# test's CHECKs and then making an actual functional change.
11+
#
12+
# Based on the title, I'd expect to see reduction in number of ur*retain/release
13+
# calls, but it only moves a few ur*release CHECKs, so I'll let the author
14+
# update this explanation.
15+
KernelAndProgram/disable-caching.cpp
16+
17+
# https://github.com/intel/llvm/pull/19238
18+
NonUniformGroups/opportunistic_group.cpp
19+
20+
# The test is extremely hacky and relies on CI installing some extra files that
21+
# are used during test execution. Looks like we need that to come from the
22+
# toolchain used to build the test, not the toolchain we're using SYCL RT from
23+
# to run against pre-built E2E binaries.
24+
Basic/device_config_file_consistency.cpp

0 commit comments

Comments
 (0)