[lld-macho] Set 4-byte alignment for __init_offsets

BertalanD · BertalanD · commit 948fc66f5e86 · 2022-11-10T23:32:55.000+01:00
dyld refuses to run initializers if this section is unaligned. Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=1383240 Differential Revision: https://reviews.llvm.org/D137803
diff --git a/lld/MachO/SyntheticSections.cpp b/lld/MachO/SyntheticSections.cpp
@@ -1899,6 +1899,7 @@ void ObjCImageInfoSection::writeTo(uint8_t *buf) const {
 InitOffsetsSection::InitOffsetsSection()
     : SyntheticSection(segment_names::text, section_names::initOffsets) {
   flags = S_INIT_FUNC_OFFSETS;
+  align = 4; // This section contains 32-bit integers.
 }
 
 uint64_t InitOffsetsSection::getSize() const {
diff --git a/lld/test/MachO/init-offsets.s b/lld/test/MachO/init-offsets.s
@@ -27,7 +27,7 @@
 # FLAGS-NEXT:     addr
 # FLAGS-NEXT:     size 0x0000000000000010
 # FLAGS-NEXT:   offset
-# FLAGS-NEXT:    align
+# FLAGS-NEXT:    align 2^2 (4)
 # FLAGS-NEXT:   reloff 0
 # FLAGS-NEXT:   nreloc 0
 # FLAGS-NEXT:     type S_INIT_FUNC_OFFSETS

Original file line number	Diff line number	Diff line change
`@@ -1899,6 +1899,7 @@ void ObjCImageInfoSection::writeTo(uint8_t *buf) const {`
`1899`	`1899`	`InitOffsetsSection::InitOffsetsSection()`
`1900`	`1900`	`: SyntheticSection(segment_names::text, section_names::initOffsets) {`
`1901`	`1901`	`flags = S_INIT_FUNC_OFFSETS;`
	`1902`	`+ align = 4; // This section contains 32-bit integers.`
`1902`	`1903`	`}`
`1903`	`1904`
`1904`	`1905`	`uint64_t InitOffsetsSection::getSize() const {`