Skip to content

Commit 95b8620

Browse files
aarongreigaarongreig
committed
Merge branch 'sycl' into aaron/reworkDestructorDependencies
2 parents f83214d + 88827d4 commit 95b8620

File tree

199 files changed

+8447
-1498
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

199 files changed

+8447
-1498
lines changed

‎.github/workflows/sycl-linux-precommit.yml‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ jobs:
6363
runner: '["Linux", "gen12"]'
6464
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
6565
target_devices: level_zero:gpu;opencl:gpu;opencl:cpu
66-
reset_intel_gpu: true
6766
extra_lit_opts: --param gpu-intel-gen12=True
6867
- name: NVIDIA/CUDA
6968
runner: '["Linux", "cuda"]'
@@ -73,46 +72,39 @@ jobs:
7372
runner: '["Linux", "amdgpu"]'
7473
image_options: -u 1001 --device=/dev/dri --device=/dev/kfd
7574
target_devices: hip:gpu
76-
reset_intel_gpu: false
7775
extra_lit_opts: -j 1
7876
- name: Intel Arc A-Series Graphics
7977
runner: '["Linux", "arc"]'
8078
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
8179
target_devices: level_zero:gpu;opencl:gpu;level_zero_v2:gpu
82-
reset_intel_gpu: true
8380
extra_lit_opts: --param matrix-xmx8=True
8481
- name: E2E tests with dev igc on Intel Arc A-Series Graphics
8582
runner: '["Linux", "arc"]'
8683
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
8784
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
8885
target_devices: level_zero:gpu;opencl:gpu
89-
reset_intel_gpu: true
9086
extra_lit_opts: --param matrix-xmx8=True
9187
use_igc_dev: true
9288
- name: E2E tests on Intel Ponte Vecchio GPU
9389
runner: '["Linux", "pvc"]'
9490
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
9591
target_devices: level_zero:gpu;opencl:gpu
96-
reset_intel_gpu: true
9792
extra_lit_opts: -j 50
9893
- name: Dev IGC on Intel Ponte Vecchio GPU
9994
runner: '["Linux", "pvc"]'
10095
image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
10196
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
10297
target_devices: level_zero:gpu;opencl:gpu
103-
reset_intel_gpu: true
10498
use_igc_dev: true
10599
extra_lit_opts: -j 50
106100
- name: Intel Battlemage Graphics
107101
runner: '["Linux", "bmg"]'
108102
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
109103
target_devices: level_zero:gpu
110-
reset_intel_gpu: true
111104
- name: SPIR-V Backend / Intel Battlemage Graphics
112105
runner: '["Linux", "bmg"]'
113106
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
114107
target_devices: level_zero:gpu;opencl:gpu;opencl:cpu
115-
reset_intel_gpu: true
116108
extra_lit_opts: --param spirv-backend=True
117109
e2e_binaries_artifact: sycl_e2e_bin_default_spirv_backend
118110
uses: ./.github/workflows/sycl-linux-run-tests.yml
@@ -123,7 +115,6 @@ jobs:
123115
image_options: ${{ matrix.image_options }}
124116
target_devices: ${{ matrix.target_devices }}
125117
extra_lit_opts: ${{ matrix.extra_lit_opts }}
126-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
127118
repo_ref: ${{ github.sha }}
128119
sycl_toolchain_artifact: sycl_linux_default
129120
sycl_toolchain_archive: ${{ needs.build.outputs.artifact_archive_name }}
@@ -159,11 +150,9 @@ jobs:
159150
- name: Intel GEN12 Graphics system
160151
runner: '["Linux", "gen12"]'
161152
image_extra_opts: --device=/dev/dri
162-
reset_intel_gpu: true
163153
- name: Intel Arc A-Series Graphics system
164154
runner: '["Linux", "arc"]'
165155
image_extra_opts: --device=/dev/dri
166-
reset_intel_gpu: true
167156
- name: AMD system
168157
runner: '["Linux", "amdgpu"]'
169158
image_extra_opts: --device=/dev/dri --device=/dev/kfd
@@ -176,7 +165,6 @@ jobs:
176165
runner: ${{ matrix. runner }}
177166
image_options: -u 1001 --privileged --cap-add SYS_ADMIN ${{ matrix.image_extra_opts }}
178167
target_devices: all
179-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
180168

181169
env: '{"LIT_FILTER":"PerformanceTests/"}'
182170
extra_lit_opts: -a -j 1 --param enable-perf-tests=True

‎.github/workflows/sycl-linux-run-tests.yml‎

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ on:
8282
type: string
8383
default: 1
8484

85-
reset_intel_gpu:
86-
type: string
87-
required: False
8885
install_igc_driver:
8986
type: string
9087
required: False
@@ -171,14 +168,6 @@ on:
171168
Extra options to be added to LIT_OPTS.
172169
default: ''
173170

174-
reset_intel_gpu:
175-
description: |
176-
Reset Intel GPUs
177-
type: choice
178-
options:
179-
- false
180-
- true
181-
182171
e2e_testing_mode:
183172
type: choice
184173
options:
@@ -199,31 +188,15 @@ jobs:
199188
options: ${{ inputs.image_options }}
200189
env: ${{ fromJSON(inputs.env) }}
201190
steps:
202-
- name: Reset Intel GPU
203-
if: inputs.reset_intel_gpu == 'true'
204-
shell: bash
205-
run: |
206-
if [[ '${{ inputs.runner }}' == '["Linux", "bmg"]' ]]; then
207-
sudo bash -c 'echo 0000:05:00.0 > /sys/bus/pci/drivers/xe/unbind'
208-
sudo bash -c 'echo 1 > /sys/bus/pci/devices/0000:05:00.0/reset'
209-
sudo bash -c 'echo 0000:05:00.0 > /sys/bus/pci/drivers/xe/bind'
210-
else
211-
sudo mount -t debugfs none /sys/kernel/debug
212-
base_dir="/sys/kernel/debug/dri"
213-
214-
for dir in "$base_dir"/*; do
215-
if [ -f "$dir/i915_wedged" ]; then
216-
sudo bash -c 'echo 1 > $0/i915_wedged' $dir
217-
fi
218-
done
219-
fi
220191
- uses: actions/checkout@v4
221192
with:
222193
ref: ${{ inputs.devops_ref || inputs.repo_ref }}
223194
sparse-checkout: |
224195
devops
225196
- name: Register cleanup after job is finished
226197
uses: ./devops/actions/cleanup
198+
- name: Reset Intel GPU
199+
uses: ./devops/actions/reset_gpu
227200
- name: Install drivers
228201
if: inputs.install_igc_driver == 'true' || inputs.install_dev_igc_driver == 'true'
229202
env:

‎.github/workflows/sycl-nightly.yml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,31 +70,26 @@ jobs:
7070
runner: '["Linux", "gen12"]'
7171
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
7272
target_devices: level_zero:gpu
73-
reset_intel_gpu: true
7473

7574
- name: Intel L0 Ponte Vecchio GPU
7675
runner: '["Linux", "pvc"]'
7776
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
7877
target_devices: level_zero:gpu
79-
reset_intel_gpu: true
8078

8179
- name: Intel L0 Battlemage GPU
8280
runner: '["Linux", "bmg"]'
8381
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
8482
target_devices: level_zero:gpu
85-
reset_intel_gpu: true
8683

8784
- name: Intel L0 Arc A-Series GPU
8885
runner: '["Linux", "arc"]'
8986
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
9087
target_devices: level_zero:gpu
91-
reset_intel_gpu: true
9288

9389
- name: Intel OCL Gen12 GPU
9490
runner: '["Linux", "gen12"]'
9591
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
9692
target_devices: opencl:gpu
97-
reset_intel_gpu: true
9893

9994
- name: OCL CPU (AMD)
10095
runner: '["Linux", "amdcpu"]'
@@ -115,7 +110,6 @@ jobs:
115110
runner: '["Linux", "pvc"]'
116111
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
117112
target_devices: level_zero:gpu
118-
reset_intel_gpu: true
119113
extra_lit_opts: --param test-preview-mode=True
120114

121115
uses: ./.github/workflows/sycl-linux-run-tests.yml
@@ -126,7 +120,6 @@ jobs:
126120
target_devices: ${{ matrix.target_devices }}
127121
tests_selector: e2e
128122
extra_lit_opts: "--param 'cxx_flags=-D_GLIBCXX_USE_CXX11_ABI=0' ${{ matrix.extra_lit_opts }}"
129-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
130123
repo_ref: ${{ github.sha }}
131124
sycl_toolchain_artifact: sycl_linux_default
132125
sycl_toolchain_archive: ${{ needs.ubuntu2204_build.outputs.artifact_archive_name }}
@@ -140,7 +133,6 @@ jobs:
140133
name: Intel PVC L0 oneAPI
141134
runner: '["Linux", "pvc"]'
142135
target_devices: level_zero:gpu
143-
reset_intel_gpu: true
144136
extra_lit_opts: -j 50
145137
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
146138
repo_ref: ${{ github.sha }}
@@ -302,7 +294,6 @@ jobs:
302294
runner: '["PVC_PERF"]'
303295
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
304296
target_devices: level_zero:gpu
305-
reset_intel_gpu: true
306297
uses: ./.github/workflows/sycl-linux-run-tests.yml
307298
secrets: inherit
308299
with:
@@ -311,7 +302,6 @@ jobs:
311302
image_options: ${{ matrix.image_options }}
312303
target_devices: ${{ matrix.target_devices }}
313304
tests_selector: compute-benchmarks
314-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
315305
repo_ref: ${{ github.sha }}
316306
sycl_toolchain_artifact: sycl_linux_default
317307
sycl_toolchain_archive: ${{ needs.ubuntu2204_build.outputs.artifact_archive_name }}

‎.github/workflows/sycl-post-commit.yml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,9 @@ jobs:
5353
- name: Intel GEN12 Graphics with Level Zero
5454
runner: '["Linux", "gen12"]'
5555
target_devices: level_zero:gpu
56-
reset_intel_gpu: true
5756
- name: Intel Arc A-Series Graphics with Level Zero
5857
runner: '["Linux", "arc"]'
5958
extra_lit_opts: --param matrix-xmx8=True
60-
reset_intel_gpu: true
61-
- name: AMD/HIP
62-
runner: '["Linux", "amdgpu"]'
63-
image_options: -u 1001 --device=/dev/dri --device=/dev/kfd
64-
target_devices: hip:gpu
65-
reset_intel_gpu: false
6659
# Performance tests below. Specifics:
6760
# - only run performance tests (use LIT_FILTER env)
6861
# - ask llvm-lit to show all the output, even for PASS (-a)
@@ -74,20 +67,17 @@ jobs:
7467
env: '{"LIT_FILTER":"PerformanceTests/"}'
7568
extra_lit_opts: -a -j 1 --param enable-perf-tests=True
7669
target_devices: all
77-
reset_intel_gpu: true
7870
- name: Perf tests on Intel Arc A-Series Graphics system
7971
runner: '["Linux", "arc"]'
8072
env: '{"LIT_FILTER":"PerformanceTests/"}'
8173
extra_lit_opts: -a -j 1 --param enable-perf-tests=True
8274
target_devices: all
83-
reset_intel_gpu: true
8475
uses: ./.github/workflows/sycl-linux-run-tests.yml
8576
with:
8677
name: ${{ matrix.name }}
8778
runner: ${{ matrix. runner }}
8879
image_options: ${{ matrix.image_options || '-u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN' }}
8980
target_devices: ${{ matrix.target_devices || 'level_zero:gpu' }}
90-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
9181

9282
extra_lit_opts: ${{ matrix.extra_lit_opts }}
9383
env: ${{ matrix.env || '{}' }}

‎.github/workflows/sycl-rel-nightly.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,13 @@ jobs:
6363
runner: '["Linux", "gen12"]'
6464
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
6565
target_devices: level_zero:gpu
66-
reset_intel_gpu: true
6766
tests_selector: e2e
6867
extra_lit_opts: --param gpu-intel-gen12=True
6968

7069
- name: Intel OCL GPU
7170
runner: '["Linux", "gen12"]'
7271
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
7372
target_devices: opencl:gpu
74-
reset_intel_gpu: true
7573
tests_selector: e2e
7674
extra_lit_opts: --param gpu-intel-gen12=True
7775

@@ -88,7 +86,6 @@ jobs:
8886
target_devices: ${{ matrix.target_devices }}
8987
tests_selector: ${{ matrix.tests_selector }}
9088
extra_lit_opts: ${{ matrix.extra_lit_opts }}
91-
reset_intel_gpu: ${{ matrix.reset_intel_gpu }}
9289
repo_ref: sycl-rel-6_1_0
9390
devops_ref: sycl
9491
sycl_toolchain_artifact: sycl_linux_default

‎.github/workflows/sycl-windows-run-tests.yml‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,22 @@ jobs:
149149
cmake -GNinja -B build-e2e -S.\llvm\sycl\test-e2e -DSYCL_TEST_E2E_TARGETS="level_zero:gpu" -DCMAKE_CXX_COMPILER="clang++" -DLEVEL_ZERO_LIBS_DIR="D:\\github\\level-zero_win-sdk\\lib" -DLEVEL_ZERO_INCLUDE="D:\\github\\level-zero_win-sdk\\include" -DLLVM_LIT="..\\llvm\\llvm\\utils\\lit\\lit.py"
150150
- name: Run End-to-End tests
151151
if: inputs.tests_selector == 'e2e'
152-
shell: bash
152+
shell: bash {0}
153153
run: |
154154
# Run E2E tests.
155155
if [[ ${{inputs.compiler}} == 'icx' ]]; then
156156
export LIT_FILTER_OUT="compile_on_win_with_mdd"
157157
fi
158158
export LIT_OPTS="-v --no-progress-bar --show-unsupported --show-pass --show-xfail --max-time 3600 --time-tests ${{ inputs.extra_lit_opts }}"
159-
cmake --build build-e2e --target check-sycl-e2e
159+
cmake --build build-e2e --target check-sycl-e2e > e2e.log 2>&1
160+
161+
exit_code=$?
162+
cat e2e.log
163+
if [ $exit_code -ne 0 ]; then
164+
# This is duplicated between lin/win, updates must change both.
165+
awk '/^Failed Tests|Unexpectedly Passed Tests|Unresolved tests|Timed Out Tests|Testing Time/{flag=1}/FAILED: CMakeFiles/{flag=0}flag' e2e.log >> $GITHUB_STEP_SUMMARY
166+
fi
167+
exit $exit_code
160168
161169
- name: Run SYCL CTS Tests
162170
if: inputs.tests_selector == 'cts'

‎.github/workflows/ur-source-checks.yml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
if: matrix.os == 'ubuntu-22.04'
3434
run: |
3535
sudo apt-get update
36-
sudo apt-get install -y doxygen
36+
sudo apt-get install -y doxygen libhwloc-dev
3737
3838
- name: "[Win] Install doxygen"
3939
if: matrix.os == 'windows-2022'
@@ -53,7 +53,6 @@ jobs:
5353
-DCMAKE_BUILD_TYPE=Debug
5454
-DUR_BUILD_TESTS=OFF
5555
-DUR_FORMAT_CPP_STYLE=ON
56-
-DUMF_DISABLE_HWLOC=ON
5756
5857
# Verifying license should be enough on a single OS
5958
- name: Verify that each source file contains a license

‎clang/include/clang/Basic/Attr.td‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1606,12 +1606,12 @@ def SYCLType: InheritableAttr {
16061606
let Subjects = SubjectList<[CXXRecord, Enum], ErrorDiag>;
16071607
let LangOpts = [SYCLIsDevice, SilentlyIgnoreSYCLIsHost];
16081608
let Args = [EnumArgument<"Type", "SYCLType", /*is_string=*/true,
1609-
["accessor", "local_accessor", "work_group_memory",
1609+
["accessor", "local_accessor", "work_group_memory", "dynamic_work_group_memory",
16101610
"specialization_id", "kernel_handler", "buffer_location",
16111611
"no_alias", "accessor_property_list", "group",
16121612
"private_memory", "aspect", "annotated_ptr", "annotated_arg",
16131613
"stream", "sampler", "host_pipe", "multi_ptr"],
1614-
["accessor", "local_accessor", "work_group_memory",
1614+
["accessor", "local_accessor", "work_group_memory", "dynamic_work_group_memory",
16151615
"specialization_id", "kernel_handler", "buffer_location",
16161616
"no_alias", "accessor_property_list", "group",
16171617
"private_memory", "aspect", "annotated_ptr", "annotated_arg",

‎clang/include/clang/Sema/SemaSYCL.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ class SYCLIntegrationHeader {
6363
kind_specialization_constants_buffer,
6464
kind_stream,
6565
kind_work_group_memory,
66-
kind_last = kind_work_group_memory
66+
kind_dynamic_work_group_memory,
67+
kind_last = kind_dynamic_work_group_memory
6768
};
6869

6970
public:

0 commit comments

Comments
 (0)