[NFCI][SYCL] Generalize device_impl's properties caching (#18476)

I think this is better than a simpler
#18450 as it allows much easier
experiments/tuning on what should be cached and how.

Author: aelovikov-intel

sycl/gdb/libsycl.so-gdb.py

@@ -374,8 +374,7 @@ def range_common_array(self):
 class SYCLDevice(SYCLValue):
     """Provides information about a sycl::device from a gdb.Value."""
 
-    IMPL_OFFSET_TO_DEVICE_TYPE = 0x18
-    IMPL_OFFSET_TO_PLATFORM = 0x28
+    IMPL_OFFSET_TO_PLATFORM = 0x18
     PLATFORM_OFFSET_TO_BACKEND = 0x20
 
     def __init__(self, gdb_value):
@@ -384,14 +383,6 @@ def __init__(self, gdb_value):
     def impl_ptr(self):
         return self.gdb_value()["impl"]["_M_ptr"]
 
-    def device_type(self):
-        char_ptr = SYCLType.char_type().pointer()
-        device_addr = self.impl_ptr().cast(char_ptr)
-        device_type_addr = device_addr + self.IMPL_OFFSET_TO_DEVICE_TYPE
-        uint32t_ptr = gdb.lookup_type("uint32_t").pointer()
-        device_type = device_type_addr.cast(uint32t_ptr).dereference()
-        return device_type
-
     def backend(self):
         char_ptr = SYCLType.char_type().pointer()
         impl_ptr = self.impl_ptr().cast(char_ptr)

sycl/source/detail/device_impl.cpp

@@ -24,25 +24,15 @@ namespace detail {
 device_impl::device_impl(ur_device_handle_t Device, platform_impl &Platform,
                          device_impl::private_tag)
     : MDevice(Device), MPlatform(Platform.shared_from_this()),
-      MDeviceHostBaseTime(std::make_pair(0, 0)) {
-  const AdapterPtr &Adapter = Platform.getAdapter();
-
-  // TODO catch an exception and put it to list of asynchronous exceptions
-  MType = get_info_impl<UR_DEVICE_INFO_TYPE>();
-
-  // No need to set MRootDevice when MAlwaysRootDevice is true
-  // TODO: Is get_info aligned with this?
-  if (!Platform.MAlwaysRootDevice) {
-    // TODO catch an exception and put it to list of asynchronous exceptions
-    MRootDevice = get_info_impl<UR_DEVICE_INFO_PARENT_DEVICE>();
-  }
-
-  // TODO catch an exception and put it to list of asynchronous exceptions
+      // No need to set MRootDevice when MAlwaysRootDevice is true
+      MRootDevice(Platform.MAlwaysRootDevice
+                      ? nullptr
+                      : get_info_impl<UR_DEVICE_INFO_PARENT_DEVICE>()),
+      // TODO catch an exception and put it to list of asynchronous exceptions:
+      MCache{*this} {
   // Interoperability Constructor already calls DeviceRetain in
   // urDeviceCreateWithNativeHandle.
-  Adapter->call<UrApiKind::urDeviceRetain>(MDevice);
-
-  MUseNativeAssert = get_info_impl<UR_DEVICE_INFO_USE_NATIVE_ASSERT>();
+  getAdapter()->call<UrApiKind::urDeviceRetain>(MDevice);
 }
 
 device_impl::~device_impl() {
@@ -415,7 +405,7 @@ bool device_impl::has(aspect Aspect) const {
   case aspect::ext_oneapi_srgb:
     return get_info<info::device::ext_oneapi_srgb>();
   case aspect::ext_oneapi_native_assert:
-    return useNativeAssert();
+    return get_info_impl<UR_DEVICE_INFO_USE_NATIVE_ASSERT>();
   case aspect::ext_oneapi_cuda_async_barrier: {
     return get_info_impl_nocheck<UR_DEVICE_INFO_ASYNC_BARRIER>().value_or(0);
   }
@@ -649,24 +639,6 @@ bool device_impl::has(aspect Aspect) const {
   return false; // This device aspect has not been implemented yet.
 }
 
-bool device_impl::useNativeAssert() const { return MUseNativeAssert; }
-
-std::string device_impl::getDeviceName() const {
-  std::call_once(MDeviceNameFlag,
-                 [this]() { MDeviceName = get_info<info::device::name>(); });
-
-  return MDeviceName;
-}
-
-ext::oneapi::experimental::architecture device_impl::getDeviceArch() const {
-  std::call_once(MDeviceArchFlag, [this]() {
-    MDeviceArch =
-        get_info<ext::oneapi::experimental::info::device::architecture>();
-  });
-
-  return MDeviceArch;
-}
-
 // On the first call this function queries for device timestamp
 // along with host synchronized timestamp and stores it in member variable
 // MDeviceHostBaseTime. Subsequent calls to this function would just retrieve