Skip to content

Commit 9687090

Browse files
schittirKornevNikita
authored andcommitted
[NFC] Avoid potential nullptr deref by using castAs<> (#123395)
Use castAs<> instead of getAs<>
1 parent d8614b1 commit 9687090

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

clang/lib/CodeGen/CGBuiltin.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18885,9 +18885,9 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID,
1888518885
assert(T0->isVectorTy() && T1->isVectorTy() &&
1888618886
"Dot product of vector and scalar is not supported.");
1888718887

18888-
auto *VecTy0 = E->getArg(0)->getType()->getAs<VectorType>();
18888+
auto *VecTy0 = E->getArg(0)->getType()->castAs<VectorType>();
1888918889
[[maybe_unused]] auto *VecTy1 =
18890-
E->getArg(1)->getType()->getAs<VectorType>();
18890+
E->getArg(1)->getType()->castAs<VectorType>();
1889118891

1889218892
assert(VecTy0->getElementType() == VecTy1->getElementType() &&
1889318893
"Dot product of vectors need the same element types.");
@@ -18958,7 +18958,7 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
1895818958
llvm::Type *Xty = Op0->getType();
1895918959
llvm::Type *retType = llvm::Type::getInt1Ty(this->getLLVMContext());
1896018960
if (Xty->isVectorTy()) {
18961-
auto *XVecTy = E->getArg(0)->getType()->getAs<VectorType>();
18961+
auto *XVecTy = E->getArg(0)->getType()->castAs<VectorType>();
1896218962
retType = llvm::VectorType::get(
1896318963
retType, ElementCount::getFixed(XVecTy->getNumElements()));
1896418964
}
@@ -19102,7 +19102,7 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
1910219102
llvm::Type *Xty = Op0->getType();
1910319103
llvm::Type *retType = llvm::Type::getInt32Ty(this->getLLVMContext());
1910419104
if (Xty->isVectorTy()) {
19105-
auto *XVecTy = Arg0->getType()->getAs<VectorType>();
19105+
auto *XVecTy = Arg0->getType()->castAs<VectorType>();
1910619106
retType = llvm::VectorType::get(
1910719107
retType, ElementCount::getFixed(XVecTy->getNumElements()));
1910819108
}

0 commit comments

Comments
 (0)