Merge from 'sycl' to 'sycl-web' (37 commits)

Author: iclsrc

.github/workflows/sycl-linux-precommit.yml

@@ -111,14 +111,12 @@ jobs:
             runner: '["Linux", "pvc"]'
             image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
             target_devices: level_zero:gpu;opencl:gpu
-            extra_lit_opts: -j 50
           - name: Dev IGC on Intel Ponte Vecchio GPU
             runner: '["Linux", "pvc"]'
             image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc
             image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
             target_devices: level_zero:gpu;opencl:gpu
             use_igc_dev: true
-            extra_lit_opts: -j 50
           - name: Intel Battlemage Graphics
             runner: '["Linux", "bmg"]'
             image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN

.github/workflows/sycl-nightly.yml

@@ -249,7 +249,7 @@ jobs:
     uses: ./.github/workflows/sycl-windows-run-tests.yml
     with:
       name: Build SYCL-CTS for Windows
-      runner: '["Windows", "build-e2e"]'
+      runner: '["Windows", "build"]'
       cts_testing_mode: 'build-only'
       tests_selector: cts
       repo_ref: ${{ github.sha }}

.github/workflows/sycl-post-commit.yml

@@ -117,6 +117,7 @@ jobs:
     with:
       name: Intel GEN12 Graphics with Level Zero
       runner: '["Windows","gen12"]'
+      target_devices: "level_zero:gpu"
       sycl_toolchain_archive: ${{ needs.build-win.outputs.artifact_archive_name }}
       compiler: icx
 

.github/workflows/sycl-windows-build.yml

@@ -25,6 +25,9 @@ on:
         description: 'Artifacts retention period'
         type: string
         default: 3
+      e2e_binaries_artifact:
+        type: string
+        required: false
       compiler:
         type: string
         required: false
@@ -226,6 +229,22 @@ jobs:
         name: sycl_windows_default
         path: ${{ inputs.artifact_archive_name }}
         retention-days: ${{ inputs.retention-days }}
+
+    - name: Setup SYCL toolchain
+      run: |
+        echo "PATH=$env:GITHUB_WORKSPACE\\install\\bin;$env:PATH" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+        echo "LIB=$env:GITHUB_WORKSPACE\\install\\lib;$env:LIB" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+
+    - name: Build E2E tests
+      if: ${{ inputs.e2e_binaries_artifact && always() && !cancelled() && steps.build.conclusion == 'success' }}
+      uses: ./devops/actions/run-tests/windows/e2e
+      with:
+        ref: ${{ inputs.ref || github.sha }}
+        testing_mode: build-only
+        target_devices: all
+        binaries_artifact: ${{ inputs.e2e_binaries_artifact }}
+        extra_lit_opts: --param sycl_build_targets="spir"
+
     - name:  Detect hung tests
       if: always()
       shell: powershell

.github/workflows/sycl-windows-precommit.yml

@@ -49,25 +49,10 @@ jobs:
     uses: ./.github/workflows/sycl-windows-build.yml
     with:
       changes: ${{ needs.detect_changes.outputs.filters }}
-
-  build-e2e:
-    needs: build
-    # Continue if build was successful.
-    if: |
-      always()
-      && !cancelled()
-      && needs.build.outputs.build_conclusion == 'success'
-    uses: ./.github/workflows/sycl-windows-run-tests.yml
-    with:
-      name: Build Windows E2E tests
-      runner: '["Windows", "build-e2e"]'
-      sycl_toolchain_archive: ${{ needs.build.outputs.artifact_archive_name }}
-      e2e_testing_mode: build-only
-      extra_lit_opts: --param sycl_build_targets="spir"
       e2e_binaries_artifact: sycl_windows_e2ebin
 
   run_prebuilt_e2e_tests:
-    needs: [build, build-e2e]
+    needs: build
     # Continue if build was successful.
     if: |
       always()
@@ -85,6 +70,7 @@ jobs:
     with:
       name: ${{ matrix.name }}
       runner: ${{ matrix.runner }}
+      target_devices: "level_zero:gpu"
       sycl_toolchain_archive: ${{ needs.build.outputs.artifact_archive_name }}
       e2e_testing_mode: run-only
       e2e_binaries_artifact: sycl_windows_e2ebin

.github/workflows/sycl-windows-run-tests.yml

@@ -152,73 +152,19 @@ jobs:
     - run: |
         sycl-ls --verbose
 
-    - name: Download E2E Binaries
-      if: ${{ inputs.tests_selector == 'e2e' && inputs.e2e_testing_mode == 'run-only' }}
-      uses: actions/download-artifact@v4
-      with:
-        name: ${{ inputs.e2e_binaries_artifact }}
-    - name: Extract E2E Binaries
-      if: ${{ inputs.tests_selector == 'e2e' && inputs.e2e_testing_mode == 'run-only' }}
-      shell: bash
-      run: |
-        mkdir build-e2e
-        tar -xf e2e_bin.tar.gz -C build-e2e
-
-    - name: Configure E2E with Level Zero target
-      if: inputs.tests_selector == 'e2e'
-      shell: cmd
-      run: |
-        mkdir build-e2e
-        cmake -GNinja -B build-e2e -S.\llvm\sycl\test-e2e -DSYCL_TEST_E2E_TARGETS="level_zero:gpu" -DCMAKE_CXX_COMPILER="clang++" -DLEVEL_ZERO_LIBS_DIR="D:\\github\\level-zero_win-sdk\\lib" -DLEVEL_ZERO_INCLUDE="D:\\github\\level-zero_win-sdk\\include" -DLLVM_LIT="..\\llvm\\llvm\\utils\\lit\\lit.py"
-
-    - name: Keep track of files after configuring E2E step
-      if: ${{ always() && inputs.tests_selector == 'e2e' && inputs.e2e_testing_mode == 'build-only' }}
-      shell: bash
-      run: ls build-e2e > e2econf_files.txt
-
-    - name: Run End-to-End tests
+    - name: Run E2E Tests
       if: inputs.tests_selector == 'e2e'
-      shell: bash {0}
-      env:
-        LIT_OPTS: -v --no-progress-bar --show-unsupported --show-pass --show-xfail --max-time ${{ inputs.e2e_testing_mode == 'run-only' && 1200 || 3600 }} --time-tests --param print_features=True --param test-mode=${{ inputs.e2e_testing_mode }} ${{ inputs.extra_lit_opts }}
-      run: |
-        # Run E2E tests.
-        if [[ ${{inputs.compiler}} == 'icx' ]]; then
-           export LIT_FILTER_OUT="compile_on_win_with_mdd"
-        fi
-        cmake --build build-e2e --target check-sycl-e2e > e2e.log 2>&1
-
-        exit_code=$?
-        cat e2e.log
-        if [ $exit_code -ne 0 ]; then
-          # This is duplicated between lin/win, updates must change both.
-          awk '/^Failed Tests|Unexpectedly Passed Tests|Unresolved tests|Timed Out Tests|Testing Time/{flag=1}/FAILED: CMakeFiles/{flag=0}flag' e2e.log >> $GITHUB_STEP_SUMMARY
-        fi
-        exit $exit_code
-
-    # Github CI doesn't support containers on Windows, so we cannot guarantee
-    # that paths are the same between building and running systems. To avoid
-    # CMake issues related to absolute paths we reconfigure the build-e2e
-    # folder on the run system.
-    - name: Remove E2E configuration files
-      if: ${{ always() && inputs.tests_selector == 'e2e' && inputs.e2e_testing_mode == 'build-only' }}
-      shell: bash
-      run: |
-        for FILE in $(cat e2econf_files.txt); do rm -r build-e2e/$FILE; done
-        rm e2econf_files.txt
-
-    - name: Pack E2E test binaries
-      if: ${{ always() && !cancelled() && inputs.tests_selector == 'e2e' && inputs.e2e_testing_mode == 'build-only' }}
-      shell: bash
-      run: |
-        tar -czf e2e_bin.tar.gz -C build-e2e .
-    - name: Upload E2E test binaries
-      if: ${{ always() && !cancelled() && inputs.tests_selector == 'e2e' && inputs.e2e_testing_mode == 'build-only' }}
-      uses: actions/upload-artifact@v4
+      uses: ./devops/actions/run-tests/windows/e2e
+      timeout-minutes: 60
       with:
-        name: ${{ inputs.e2e_binaries_artifact }}
-        path: e2e_bin.tar.gz
-        retention-days: 3
+        ref: ${{ inputs.tests_ref || inputs.repo_ref || github.sha }}
+        binaries_artifact: ${{ inputs.e2e_binaries_artifact }}
+        testing_mode: ${{ inputs.e2e_testing_mode }}
+        extra_cmake_args: ${{ inputs.extra_cmake_args }}
+        target_devices: ${{ inputs.target_devices }}
+        extra_lit_opts: ${{ inputs.extra_lit_opts }}
+        retention-days: ${{ inputs.artifact_retention_days }}
+        compiler: ${{ inputs.compiler }}
 
     - name: Run SYCL CTS Tests
       if: inputs.tests_selector == 'cts'

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -12845,6 +12845,8 @@ def err_registered_kernels_name_already_registered : Error<
   "free function kernel has already been registered with '%0'; cannot register with '%1'">;
 def err_not_sycl_free_function : Error<
   "attempting to register a function that is not a SYCL free function as '%0'">;
+def err_free_function_variadic_args: Error<
+  "free function kernel cannot be a variadic function">;
 
 // SYCL kernel entry point diagnostics
 def err_sycl_entry_point_invalid : Error<

clang/lib/Driver/ToolChains/Clang.cpp

@@ -5383,11 +5383,6 @@ static void ProcessVSRuntimeLibrary(const ToolChain &TC, const ArgList &Args,
       CmdArgs.push_back("-D_MT");
     if (Defines & addDLL && !isSPIROrSPIRV)
       CmdArgs.push_back("-D_DLL");
-    // for /MDd with spir targets
-    if ((Defines & addDLL) && (Defines & addDEBUG) && isSPIROrSPIRV) {
-      CmdArgs.push_back("-D_CONTAINER_DEBUG_LEVEL=0");
-      CmdArgs.push_back("-D_ITERATOR_DEBUG_LEVEL=0");
-    }
   };
   StringRef FlagForCRT;
   switch (RTOptionID) {