[SYCL] Fix race condition in submission time read/write (#18716)

Author: againull

sycl/source/detail/device_impl.cpp

@@ -331,12 +331,21 @@ uint64_t device_impl::getCurrentDeviceTime() {
 
   // To account for potential clock drift between host clock and device clock.
   // The value set is arbitrary: 200 seconds
+  std::shared_lock<std::shared_mutex> ReadLock(MDeviceHostBaseTimeMutex);
   constexpr uint64_t TimeTillRefresh = 200e9;
   assert(HostTime >= MDeviceHostBaseTime.second);
   uint64_t Diff = HostTime - MDeviceHostBaseTime.second;
 
   // If getCurrentDeviceTime is called for the first time or we have to refresh.
   if (!MDeviceHostBaseTime.second || Diff > TimeTillRefresh) {
+    ReadLock.unlock();
+    std::unique_lock<std::shared_mutex> WriteLock(MDeviceHostBaseTimeMutex);
+    // Recheck the condition after acquiring the write lock.
+    if (MDeviceHostBaseTime.second && Diff <= TimeTillRefresh) {
+      // If we are here, it means that another thread has already updated
+      // MDeviceHostBaseTime, so we can just return the current device time.
+      return MDeviceHostBaseTime.first + Diff;
+    }
     const auto &Adapter = getAdapter();
     auto Result = Adapter->call_nocheck<UrApiKind::urDeviceGetGlobalTimestamps>(
         MDevice, &MDeviceHostBaseTime.first, &MDeviceHostBaseTime.second);

sycl/source/detail/device_impl.hpp

@@ -19,6 +19,7 @@
 
 #include <memory>
 #include <mutex>
+#include <shared_mutex>
 #include <utility>
 
 namespace sycl {
@@ -2203,7 +2204,7 @@ class device_impl : public std::enable_shared_from_this<device_impl> {
   // This is used for getAdapter so should be above other properties.
   std::shared_ptr<platform_impl> MPlatform;
 
-  // TODO: Does this have a race?
+  std::shared_mutex MDeviceHostBaseTimeMutex;
   std::pair<uint64_t, uint64_t> MDeviceHostBaseTime{0, 0};
 
   const ur_device_handle_t MRootDevice;