Skip to content

Commit b116cab

Browse files
[NFCI][SYCL] Drop detail::waitEvents under preview (#19377)
Previous `#if`s, especially declarations, made no sense to me.
1 parent 7187eea commit b116cab

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

sycl/include/sycl/detail/helpers.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ enum class memory_order;
4040
namespace detail {
4141
class buffer_impl;
4242

43-
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
44-
__SYCL_EXPORT void waitEvents(std::vector<sycl::event> DepEvents);
45-
#endif
46-
4743
__SYCL_EXPORT void
4844
markBufferAsInternal(const std::shared_ptr<buffer_impl> &BufImpl);
4945

sycl/source/detail/helpers.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,14 @@
2525
namespace sycl {
2626
inline namespace _V1 {
2727
namespace detail {
28-
void waitEvents(std::vector<sycl::event> DepEvents) {
28+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
29+
// Unused, only keeping for ABI compatibility reasons.
30+
__SYCL_EXPORT void waitEvents(std::vector<sycl::event> DepEvents) {
2931
for (auto SyclEvent : DepEvents) {
3032
detail::getSyclObjImpl(SyclEvent)->waitInternal();
3133
}
3234
}
35+
#endif
3336

3437
__SYCL_EXPORT void
3538
markBufferAsInternal(const std::shared_ptr<buffer_impl> &BufImpl) {

sycl/source/detail/helpers.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ class CGExecKernel;
2323
class queue_impl;
2424
class RTDeviceBinaryImage;
2525

26-
#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
27-
void waitEvents(std::vector<sycl::event> DepEvents);
28-
#endif
29-
3026
std::tuple<const RTDeviceBinaryImage *, ur_program_handle_t>
3127
retrieveKernelBinary(queue_impl &Queue, KernelNameStrRefT KernelName,
3228
CGExecKernel *CGKernel = nullptr);

0 commit comments

Comments
 (0)