Skip to content

Commit b2f8ead

Browse files
[SYCL] Pass NDRDescT to CGExecKernel::CGExecKernel() by reference (#19728)
NDRDescT contains several std::array-s, so copying is slower and std::move() has no effect.
1 parent 3c2678c commit b2f8ead

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

sycl/source/detail/cg.hpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ class CGExecKernel : public CG {
265265
bool MKernelUsesClusterLaunch = false;
266266
size_t MKernelWorkGroupMemorySize = 0;
267267

268-
CGExecKernel(NDRDescT NDRDesc, std::shared_ptr<HostKernelBase> HKernel,
268+
CGExecKernel(const NDRDescT &NDRDesc, std::shared_ptr<HostKernelBase> HKernel,
269269
std::shared_ptr<detail::kernel_impl> SyclKernel,
270270
std::shared_ptr<detail::kernel_bundle_impl> KernelBundle,
271271
CG::StorageInitHelper CGData, std::vector<ArgDesc> Args,
@@ -276,9 +276,8 @@ class CGExecKernel : public CG {
276276
CGType Type, ur_kernel_cache_config_t KernelCacheConfig,
277277
bool KernelIsCooperative, bool MKernelUsesClusterLaunch,
278278
size_t KernelWorkGroupMemorySize, detail::code_location loc = {})
279-
: CG(Type, std::move(CGData), std::move(loc)),
280-
MNDRDesc(std::move(NDRDesc)), MHostKernel(std::move(HKernel)),
281-
MSyclKernel(std::move(SyclKernel)),
279+
: CG(Type, std::move(CGData), std::move(loc)), MNDRDesc(NDRDesc),
280+
MHostKernel(std::move(HKernel)), MSyclKernel(std::move(SyclKernel)),
282281
MKernelBundle(std::move(KernelBundle)), MArgs(std::move(Args)),
283282
MKernelName(std::move(KernelName)),
284283
MKernelNameBasedCachePtr(KernelNameBasedCachePtr),

sycl/source/handler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ event handler::finalize() {
710710
// assert feature to check if kernel uses assertions
711711
#endif
712712
CommandGroup.reset(new detail::CGExecKernel(
713-
std::move(impl->MNDRDesc), std::move(MHostKernel), std::move(MKernel),
713+
impl->MNDRDesc, std::move(MHostKernel), std::move(MKernel),
714714
std::move(impl->MKernelBundle), std::move(impl->CGData),
715715
std::move(impl->MArgs), toKernelNameStrT(MKernelName),
716716
impl->MKernelNameBasedCachePtr, std::move(MStreamStorage),

0 commit comments

Comments
 (0)