Close to the final version

Author: aelovikov-intel

.github/workflows/sycl-linux-precommit.yml

@@ -56,20 +56,19 @@ jobs:
       build_image: "ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest"
       cc: clang
       cxx: clang++
-      # changes: ${{ needs.detect_changes.outputs.filters }}
-      changes: '[]'
+      changes: ${{ needs.detect_changes.outputs.filters }}
 
       toolchain_artifact: sycl_linux_default
-      # e2e_binaries_artifact: e2e_bin
-      # e2e_binaries_preview_artifact: e2e_bin_preview
+      e2e_binaries_artifact: e2e_bin
+      e2e_binaries_preview_artifact: e2e_bin_preview
 
   # If a PR changes CUDA adapter, run the build on Ubuntu 22.04 as well.
   # Ubuntu 22.04 container has CUDA 12.1 installed while Ubuntu 24.0 image
   # has CUDA 12.6.1 installed.
   # The idea is to ensure that the code works with both CUDA versions.
   build_ubuntu2204:
     needs: [detect_changes]
-    if: false && always() && !cancelled() && contains(needs.detect_changes.outputs.filters, 'ur_cuda_adapter')
+    if: always() && !cancelled() && contains(needs.detect_changes.outputs.filters, 'ur_cuda_adapter')
     uses: ./.github/workflows/sycl-linux-build.yml
     with:
       build_ref: ${{ github.sha }}
@@ -187,14 +186,13 @@ jobs:
         (contains(needs.detect_changes.outputs.filters, 'devigccfg') || contains(needs.detect_changes.outputs.filters, 'drivers')) ||
         'false' }}
       # Run only if the PR does not have the 'ci-no-devigc' label.
-      # skip_run: ${{matrix.use_igc_dev && contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') || 'false'}}
-      skip_run: ${{ matrix.image != 'ghcr.io/intel/llvm/sycl_prebuilt_tests:sycl-rel-6_2' }}
+      skip_run: ${{matrix.use_igc_dev && contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') || 'false'}}
       env: ${{ matrix.env || (contains(needs.detect_changes.outputs.filters, 'esimd') && '{}' || '{"LIT_FILTER_OUT":"ESIMD/"}') }}
 
   test_benchmark_scripts:
     needs: [build, detect_changes]
     if: |
-      false && always() && !cancelled()
+      always() && !cancelled()
       && needs.build.outputs.build_conclusion == 'success'
       && contains(needs.detect_changes.outputs.filters, 'benchmarks')
     uses: ./.github/workflows/sycl-linux-run-tests.yml
@@ -216,7 +214,7 @@ jobs:
   test-perf:
     needs: [build, detect_changes]
     if: |
-      false && always() && !cancelled()
+      always() && !cancelled()
       && needs.build.outputs.build_conclusion == 'success'
       && (contains(github.event.pull_request.labels.*.name, 'run-perf-tests')
           || contains(needs.detect_changes.outputs.filters, 'perf-tests'))

.github/workflows/sycl-windows-precommit.yml

@@ -25,6 +25,7 @@ on:
     - '.github/workflows/trivy.yml'
     - 'devops/containers/**'
     - 'devops/actions/build_container/**'
+    - 'devops/compat_ci_exclude.sycl-rel-6_2'
     - 'unified-runtime/examples/**'
     - 'unified-runtime/scripts/**'
     - 'unified-runtime/test/**'

devops/compat_ci_exclude.sycl-rel-6_2

@@ -1,12 +1,45 @@
+# Known OK:
+
+# https://github.com/intel/llvm/pull/18059 made property a no-op, so `FileCheck`
+# fails, but that isn't an actual ABI break.
+DiscardEvents/discard_events_accessors.cpp
+DiscardEvents/discard_events_using_assert_ndebug.cpp
+DiscardEvents/discard_events_usm.cpp
+DiscardEvents/invalid_event.cpp
+DiscardEvents/invalid_event_exceptions.cpp
+
+# https://github.com/intel/llvm/pull/18287
+# Throw exception instead of returning garbage
+Basic/info.cpp
+
+# Likely OK, but need author to provide justification, get approval/confirmation
+# from someone:
+
+# https://github.com/intel/llvm/pull/18565
+# This one should have probably be done in multiple PRs, first improving the
+# test's CHECKs and then making an actual functional change.
+#
+# Based on the title, I'd expect to see reduction in number of ur*retain/release
+# calls, but it only moves a few ur*release CHECKs, so I'll let the author
+# update this explanation.
+KernelAndProgram/disable-caching.cpp
+
 # https://github.com/intel/llvm/pull/18253 broke at least some of the pre-built
-# E2E binaries, but we don't provide backward compatibility for binaries built
-# with sanitizers.
+# E2E binaries, but do we really need to provide backward compatibility for
+# binaries built with sanitizers?
 Sanitizer
 
 # https://github.com/intel/llvm/pull/19238
 NonUniformGroups/opportunistic_group.cpp
 
-# https://github.com/intel/llvm/pull/18314 (need to address?)
+# https://github.com/intel/llvm/pull/17955, experimental extension
+AsyncAlloc/device/async_alloc_from_pool.cpp
+AsyncAlloc/device/async_alloc_zero_init.cpp
+AsyncAlloc/device/ooo_queue_async_alloc_from_pool.cpp
+
+# Need more investigation by the author:
+
+# https://github.com/intel/llvm/pull/18314
 Assert/assert_in_kernels.cpp
 Assert/assert_in_multiple_tus.cpp
 Assert/assert_in_multiple_tus_one_ndebug.cpp
@@ -15,25 +48,13 @@ Assert/assert_in_simultaneous_kernels.cpp
 Assert/assert_in_simultaneously_multiple_tus.cpp
 Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp
 
-# https://github.com/intel/llvm/pull/17955
-AsyncAlloc/device/async_alloc_from_pool.cpp
-AsyncAlloc/device/async_alloc_zero_init.cpp
-AsyncAlloc/device/ooo_queue_async_alloc_from_pool.cpp
-
-# https://github.com/intel/llvm/pull/18059 made property a no-op, so `FileCheck`
-# fails, but that isn't an actual ABI break.
-DiscardEvents/discard_events_accessors.cpp
-DiscardEvents/discard_events_using_assert_ndebug.cpp
-DiscardEvents/discard_events_usm.cpp
-DiscardEvents/invalid_event.cpp
-DiscardEvents/invalid_event_exceptions.cpp
-
-# https://github.com/intel/llvm/pull/17442 (unclear if need to address)
+# https://github.com/intel/llvm/pull/17442
 KernelCompiler/opencl.cpp
 KernelCompiler/opencl_cache_eviction.cpp
 KernelCompiler/opencl_queries.cpp
 
-# Pulldown https://github.com/intel/llvm/pull/18403 (why? TODO!!!)
+# https://github.com/intel/llvm/pull/18403 (pulldown, so probably offload-tools
+# team should be looking into this)
 DeviceImageDependencies/NewOffloadDriver/dynamic.cpp
 DeviceImageDependencies/NewOffloadDriver/free_function_kernels.cpp
 DeviceImageDependencies/NewOffloadDriver/math_device_lib.cpp
@@ -46,16 +67,9 @@ NewOffloadDriver/spirv_device_obj_smoke.cpp
 NewOffloadDriver/split-per-source-main.cpp
 NewOffloadDriver/sycl-external-with-optional-features.cpp
 
-# https://github.com/intel/llvm/pull/18277 (unclear if need to address)
+# https://github.com/intel/llvm/pull/18277
 InOrderEventsExt/get_last_event.cpp
 InorderQueue/in_order_ext_oneapi_submit_barrier.cpp
 
-# https://github.com/intel/llvm/pull/18565 (CHECKs reordered)
-KernelAndProgram/disable-caching.cpp
-
-# https://github.com/intel/llvm/pull/18287
-# Throw exception instead of returning garbage
-Basic/info.cpp
-
 # https://github.com/intel/llvm/pull/19328
 Adapters/interop-level-zero-buffer-ownership.cpp