[SYCL][NFC] Minor Coverity fixes (#19460)

This PR makes the following changes:
1. Use `std::move` instead of copy
2. Handle integer overflow in `registerStream` and `registerVendor`

Author: uditagarwal97

sycl/source/detail/context_impl.cpp

@@ -32,8 +32,8 @@ namespace detail {
 context_impl::context_impl(const std::vector<sycl::device> Devices,
                            async_handler AsyncHandler,
                            const property_list &PropList, private_tag)
-    : MOwnedByRuntime(true), MAsyncHandler(AsyncHandler), MDevices(Devices),
-      MContext(nullptr),
+    : MOwnedByRuntime(true), MAsyncHandler(std::move(AsyncHandler)),
+      MDevices(std::move(Devices)), MContext(nullptr),
       MPlatform(detail::getSyclObjImpl(MDevices[0].get_platform())),
       MPropList(PropList), MSupportBufferLocationByDevices(NotChecked) {
   verifyProps(PropList);

sycl/source/detail/helpers.cpp

@@ -47,7 +47,7 @@ const RTDeviceBinaryImage *retrieveKernelBinary(queue_impl &Queue,
   bool isHIP = Dev.getBackend() == backend::ext_oneapi_hip;
   if (isNvidia || isHIP) {
     auto KernelID = ProgramManager::getInstance().getSYCLKernelID(KernelName);
-    std::vector<kernel_id> KernelIds{KernelID};
+    std::vector<kernel_id> KernelIds{std::move(KernelID)};
     auto DeviceImages =
         ProgramManager::getInstance().getRawDeviceImages(KernelIds);
     auto DeviceImage = std::find_if(

xptifw/src/xpti_trace_framework.cpp

@@ -2256,7 +2256,17 @@ class Framework {
   }
 
   uint8_t registerStream(const char *StreamName) {
-    return (uint8_t)MStreamStringTable.add(StreamName);
+    xpti::string_id_t StreamID = MStreamStringTable.add(StreamName);
+
+    // string_id_t is uint32_t while return type is uint8_t, so we need to
+    // check if the ID is valid and fits into uint8_t.
+    if (StreamID == xpti::invalid_id<xpti::string_id_t>)
+      return xpti::invalid_id<uint8_t>;
+    else {
+      assert(StreamID < std::numeric_limits<uint8_t>::max() &&
+             "StreamID exceeds the maximum value for uint8_t");
+      return static_cast<uint8_t>(StreamID);
+    }
   }
 
   ///
@@ -2284,7 +2294,17 @@ class Framework {
   }
 
   uint8_t registerVendor(const char *StreamName) {
-    return (uint8_t)MVendorStringTable.add(StreamName);
+    xpti::string_id_t StreamID = MVendorStringTable.add(StreamName);
+
+    // string_id_t is uint32_t while return type is uint8_t, so we need to
+    // check if the ID is valid and fits into uint8_t.
+    if (StreamID == xpti::invalid_id<xpti::string_id_t>)
+      return xpti::invalid_id<uint8_t>;
+    else {
+      assert(StreamID < std::numeric_limits<uint8_t>::max() &&
+             "StreamID exceeds the maximum value for uint8_t");
+      return static_cast<uint8_t>(StreamID);
+    }
   }
 
   string_id_t registerString(const char *String, char **TableString) {