Skip to content

Commit bc18ad1

Browse files
[SYCL] Use -fno-discard-value-names in relevant check_device_code tests (#13716)
`REQUIRES: asserts` was a wrong fix because that "feature" is never set/doesn't exist.
1 parent 90c659e commit bc18ad1

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

sycl/test/check_device_code/group_load.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --functions "group_load" --include-generated-funcs --version 4
22
// NOTE: and manually adjusted to follow the related explicit instantiation.
3-
// RUN: %clangxx -O3 -fsycl -fsycl-device-only -S -emit-llvm -fno-sycl-instrument-device-code -o - %s | FileCheck %s
4-
5-
// Generated checks have hard-coded basic block names, so need names in the IR.
6-
// REQUIRES: asserts
3+
// RUN: %clangxx -O3 -fsycl -fsycl-device-only -fno-discard-value-names -S -emit-llvm -fno-sycl-instrument-device-code -o - %s | FileCheck %s
74

85
// Windows/linux have some slight differences in IR generation (function
96
// arguments passing and long/long long differences/mangling) that could

sycl/test/check_device_code/vector/vector_math_ops.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
// ./llvm/utils/update_cc_test_checks.py --clang=./build/bin/clang
44
// ./sycl/test/check_device_code/vector/vector_math_ops.cpp
55

6-
// RUN: %clangxx -I %sycl_include -S -emit-llvm -fno-sycl-instrument-device-code -Xclang -disable-lifetime-markers -fsycl-device-only %s -o - | FileCheck %s
7-
8-
// REQUIRES: asserts
6+
// RUN: %clangxx -I %sycl_include -fno-discard-value-names -S -emit-llvm -fno-sycl-instrument-device-code -Xclang -disable-lifetime-markers -fsycl-device-only %s -o - | FileCheck %s
97

108
// This test checks
119
// (1) the storage type of sycl::vec on device for all data types, and

0 commit comments

Comments
 (0)